From: Stephan Mueller <smueller@chronox.de>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
davem@davemloft.net, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org, t-kristo@ti.com, nsekhar@ti.com
Subject: Re: [PATCH 08/10] crypto: omap-aes: gmc: Add algo info
Date: Thu, 02 Jul 2015 11:56:34 +0200 [thread overview]
Message-ID: <11868978.OKt1rthESK@tauon.atsec.com> (raw)
In-Reply-To: <55950A72.4040004@ti.com>
Am Donnerstag, 2. Juli 2015, 15:24:58 schrieb Lokesh Vutla:
Hi Lokesh,
>>> +{
>>> + .cra_name = "gcm(aes)",
>>> + .cra_driver_name = "gcm-aes-omap",
>>> + .cra_priority = 100,
>>
>> Why did you choose the priority 100? The software implementations commonly
>> use 100. crypto/gcm.c uses the prio of the underlying cipher. In case of
>> ARM, there seem to be assembler implementations of AES which have the prio
>> of 200 or 300. So, such software implementation of gcm(aes) would have a
>> higher precedence than your hw implementation.
>
>Yes, you are right.
>Other hw algos in omap-aes also uses priority 100.
>Only sw and hw implementations are enabled right now and both are at same
>priority. And till now its lucky enough that hw algo gets picked.
Maybe those HW prios should be updated too?
Ciao
Stephan
next prev parent reply other threads:[~2015-07-02 9:56 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 5:18 [PATCH 00/10] crypto: omap-aes: Add support for GCM mode Lokesh Vutla
2015-07-02 5:18 ` [PATCH 01/10] crypto: omap-aes: Add support for lengths not aligned with AES_BLOCK_SIZE Lokesh Vutla
2015-07-02 7:53 ` Felipe Balbi
2015-07-02 9:26 ` Lokesh Vutla
2015-07-06 7:38 ` Herbert Xu
2015-07-02 5:18 ` [PATCH 02/10] crypto: omap-aes: Fix configuring of AES mode Lokesh Vutla
2015-07-02 7:57 ` Felipe Balbi
2015-07-02 9:43 ` Lokesh Vutla
2015-07-02 5:18 ` [PATCH 03/10] crypto: aead: Add aead_request_cast() api Lokesh Vutla
2015-07-02 7:58 ` Felipe Balbi
2015-07-02 9:46 ` Lokesh Vutla
2015-07-06 7:41 ` Herbert Xu
2015-07-02 5:18 ` [PATCH 04/10] crypto: omap-aes: Use BIT() macro Lokesh Vutla
2015-07-02 7:59 ` Felipe Balbi
2015-07-06 7:42 ` Herbert Xu
2015-07-02 5:18 ` [PATCH 05/10] crypto: omap-aes: Add support for GCM mode Lokesh Vutla
2015-07-02 8:04 ` Felipe Balbi
2015-07-02 10:10 ` Lokesh Vutla
2015-07-02 5:18 ` [PATCH 06/10] crypto: omap-aes: gcm: Handle inputs properly Lokesh Vutla
2015-07-02 8:04 ` Felipe Balbi
2015-07-02 10:13 ` Lokesh Vutla
2015-07-02 5:18 ` [PATCH 07/10] crypto: omap-aes: gcm: Add support for unaligned lengths Lokesh Vutla
2015-07-02 8:05 ` Felipe Balbi
2015-07-02 5:18 ` [PATCH 08/10] crypto: omap-aes: gmc: Add algo info Lokesh Vutla
2015-07-02 8:00 ` Stephan Mueller
2015-07-02 9:54 ` Lokesh Vutla
2015-07-02 9:56 ` Stephan Mueller [this message]
2015-07-06 7:35 ` Herbert Xu
2015-07-06 8:15 ` Lokesh Vutla
2015-07-02 5:18 ` [PATCH 09/10] crypto: omap-aes: gcm: Add support for PIO mode Lokesh Vutla
2015-07-02 8:06 ` Felipe Balbi
2015-07-02 10:17 ` Lokesh Vutla
2015-07-02 5:18 ` [PATCH 10/10] crypto: tcrypt: Added speed tests for Async AEAD crypto alogrithms Lokesh Vutla
2015-07-06 7:44 ` Herbert Xu
2015-07-06 8:45 ` Lokesh Vutla
2015-07-06 8:49 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11868978.OKt1rthESK@tauon.atsec.com \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=nsekhar@ti.com \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).