From: Thomas Gleixner <tglx@linutronix.de>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2/4] posix-timers: fix creation race
Date: Mon, 13 Aug 2007 09:35:22 +0200 [thread overview]
Message-ID: <1186990522.12828.94.camel@chaos> (raw)
In-Reply-To: <20070812194455.GA113@tv-sign.ru>
On Sun, 2007-08-12 at 23:44 +0400, Oleg Nesterov wrote:
> > > --- t/kernel/posix-timers.c~2_CREATE 2007-08-12 17:59:17.000000000 +0400
> > > +++ t/kernel/posix-timers.c 2007-08-12 18:11:33.000000000 +0400
> > > @@ -547,13 +547,12 @@ sys_timer_create(const clockid_t which_c
> > > new_timer->it_process = process;
> > > list_add(&new_timer->list,
> > > &process->signal->posix_timers);
> > > - spin_unlock_irqrestore(&process->sighand->siglock, flags);
> > > if (new_timer->it_sigev_notify == (SIGEV_SIGNAL|SIGEV_THREAD_ID))
> > > get_task_struct(process);
> > > } else {
> > > - spin_unlock_irqrestore(&process->sighand->siglock, flags);
> > > process = NULL;
> > > }
> > > + spin_unlock_irqrestore(&process->sighand->siglock, flags);
>
> i'll resend this patch tomorrow. We can't do spin_unlock_irqrestore(&process->...)
> if we set process = NULL above.
Doh, half of my brain seems to be still on vacation.
tglx
prev parent reply other threads:[~2007-08-13 12:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-12 17:05 [PATCH 2/4] posix-timers: fix creation race Oleg Nesterov
2007-08-12 19:05 ` Thomas Gleixner
2007-08-12 19:44 ` Oleg Nesterov
2007-08-12 19:59 ` Oleg Nesterov
2007-08-13 7:35 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1186990522.12828.94.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=oleg@tv-sign.ru \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox