* [kj] is_power_of_2 in mm/slub.c
@ 2007-08-13 13:03 vignesh babu
2007-08-13 20:48 ` Christoph Lameter
0 siblings, 1 reply; 2+ messages in thread
From: vignesh babu @ 2007-08-13 13:03 UTC (permalink / raw)
To: clameter; +Cc: linux-mm, linux-kernel, Kernel Janitors List
Replacing n & (n - 1) for power of 2 check by is_power_of_2(n)
Signed-off-by: vignesh babu <vignesh.babu@wipro.com>
---
diff --git a/mm/slub.c b/mm/slub.c
index 69d02e3..1241d14 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -20,6 +20,7 @@
#include <linux/mempolicy.h>
#include <linux/ctype.h>
#include <linux/kallsyms.h>
+#include <linux/log2.h>
/*
* Lock order:
@@ -2606,7 +2607,7 @@ void __init kmem_cache_init(void)
* around with ARCH_KMALLOC_MINALIGN
*/
BUILD_BUG_ON(KMALLOC_MIN_SIZE > 256 ||
- (KMALLOC_MIN_SIZE & (KMALLOC_MIN_SIZE - 1)));
+ !is_power_of_2(KMALLOC_MIN_SIZE));
for (i = 8; i < KMALLOC_MIN_SIZE; i += 8)
size_index[(i - 1) / 8] = KMALLOC_SHIFT_LOW;
--
Vignesh Babu BM
_____________________________________________________________
"Why is it that every time I'm with you, makes me believe in magic?"
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [kj] is_power_of_2 in mm/slub.c
2007-08-13 13:03 [kj] is_power_of_2 in mm/slub.c vignesh babu
@ 2007-08-13 20:48 ` Christoph Lameter
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Lameter @ 2007-08-13 20:48 UTC (permalink / raw)
To: vigneshbabu; +Cc: linux-mm, linux-kernel, Kernel Janitors List
Acked-by: Christoph Lameter <clameter@sgi.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-13 20:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-13 13:03 [kj] is_power_of_2 in mm/slub.c vignesh babu
2007-08-13 20:48 ` Christoph Lameter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox