[PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[joe]

Add file pattern to MAINTAINER entry

Signed-off-by: Joe Perches <joe@perches.com>

diff --git a/MAINTAINERS b/MAINTAINERS
index 36a7d25..edebf01 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1482,7 +1482,7 @@ L:	linux-kernel@vger.kernel.org
 S:	Maintained
 
 DIGI INTL. EPCA DRIVER
-P:	Digi International, Inc
+P:	Digi International Inc
 M:	Eng.Linux@digi.com
 L:	Eng.Linux@digi.com
 W:	http://www.digi.com

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Alan Cox]

On Sun, 12 Aug 2007 23:26:16 -0700
joe@perches.com wrote:

> Add file pattern to MAINTAINER entry
> 
> Signed-off-by: Joe Perches <joe@perches.com>
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 36a7d25..edebf01 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1482,7 +1482,7 @@ L:	linux-kernel@vger.kernel.org
>  S:	Maintained
>  
>  DIGI INTL. EPCA DRIVER
> -P:	Digi International, Inc
> +P:	Digi International Inc

The "," is correct and how they added themselves.

Please don't hide other types of change in a large changeset without
notice, thats not good

NAK

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Stefan Richter]

Alan Cox wrote:
> On Sun, 12 Aug 2007 23:26:16 -0700
> joe@perches.com wrote:
>>  DIGI INTL. EPCA DRIVER
>> -P:	Digi International, Inc
>> +P:	Digi International Inc
> 
> The "," is correct and how they added themselves.
> 
> Please don't hide other types of change in a large changeset without
> notice, thats not good
> 
> NAK

I'm not Joe, but I gather this change is in order to support generation
of RFC 278 headers by the proposed script.

However, rather than mangle entries in MAINTAINERS for the script, I
suggest that the script is enhanced instead.  Simplest solution:  If the
script finds punctuation and other problematic characters in the P:
field, simply omit that part from the e-mail address.
-- 
Stefan Richter
-=====-=-=== =--- -==-=
http://arcgraph.de/sr/

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Alan Cox]

> I'm not Joe, but I gather this change is in order to support generation
> of RFC 278 headers by the proposed script.

The mail system supports comma characters if you must put names in and
this is well tested both for names and for usernames (because of TOPS,
old compu$erve etc)

Fix the script

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Kok, Auke]

Stefan Richter wrote:
> Alan Cox wrote:
>> On Sun, 12 Aug 2007 23:26:16 -0700
>> joe@perches.com wrote:
>>>  DIGI INTL. EPCA DRIVER
>>> -P:	Digi International, Inc
>>> +P:	Digi International Inc
>> The "," is correct and how they added themselves.
>>
>> Please don't hide other types of change in a large changeset without
>> notice, thats not good
>>
>> NAK
> 
> I'm not Joe, but I gather this change is in order to support generation
> of RFC 278 headers by the proposed script.
> 
> However, rather than mangle entries in MAINTAINERS for the script, I
> suggest that the script is enhanced instead.  Simplest solution:  If the
> script finds punctuation and other problematic characters in the P:
> field, simply omit that part from the e-mail address.

or properly put it on "quotes":

Cc: "Digi International, Inc" <foo@bar.com>

is perfectly valid.


Auke

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Joe Perches]

On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> or properly put it on "quotes":

I'll improve the script and revert the name changes.

cheers, Joe

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Joe Perches]

On Mon, 2007-08-13 at 09:35 -0700, Joe Perches wrote:
> On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> > or properly put it on "quotes":
> 
> I'll improve the script and revert the name changes.

# check for "must quote" chars in name

sub format_email {
    my ($name, $email) = @_;

    if ($name =~ tr@,\@<>@@) {
	$formatted_email = "\"${name}\"\ \<${email}\>";
    } else {
	$formatted_email = "${name} \<${email}\>";
    }
    return $formatted_email;
}

Anyone know what chars require the name be quoted?
I've got: "," "@" "<" ">" ?

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Cal Peake]

On Mon, 13 Aug 2007, Joe Perches wrote:

> On Mon, 2007-08-13 at 09:35 -0700, Joe Perches wrote:
> > On Mon, 2007-08-13 at 09:15 -0700, Kok, Auke wrote:
> > > or properly put it on "quotes":
> > 
> > I'll improve the script and revert the name changes.
> 
> # check for "must quote" chars in name
> 
> sub format_email {
>     my ($name, $email) = @_;
> 
>     if ($name =~ tr@,\@<>@@) {
> 	$formatted_email = "\"${name}\"\ \<${email}\>";
>     } else {
> 	$formatted_email = "${name} \<${email}\>";
>     }
>     return $formatted_email;
> }
> 
> Anyone know what chars require the name be quoted?
> I've got: "," "@" "<" ">" ?

Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape 
double quotes (e.g. "Jonathan \"Jon\" Doe" <jon@example.net>).

Cheers,
-- 
Cal Peake

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Joe Perches]

On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
> Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape 
> double quotes (e.g. "Jonathan \"Jon\" Doe" <jon@example.net>).

A-Z and [[:space:]] are OK too.
I skimmed the spec, but nothing jumped out at me.

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Cal Peake]

On Mon, 13 Aug 2007, Joe Perches wrote:

> On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
> > Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape 
> > double quotes (e.g. "Jonathan \"Jon\" Doe" <jon@example.net>).
> 
> A-Z and [[:space:]] are OK too.

The 'i' at the end of the regex means case-insensitive ;) but yes, I 
forgot whitespace. So something like:

  if ($name =~ /[^a-z0-9[:space:]]/i) {
    quote_name;
  }

> I skimmed the spec, but nothing jumped out at me.

My recommendation was mostly based on what pine does. It seems to be a 
pretty sane MUA...

-- 
Cal Peake

Re: [PATCH] [154/2many] MAINTAINERS - DIGI INTL. EPCA DRIVER

[Stefan Richter]

Cal Peake wrote:
> On Mon, 13 Aug 2007, Joe Perches wrote:
> 
>> On Tue, 2007-08-14 at 00:29 -0400, Cal Peake wrote:
>>> Prolly /[^a-z0-9]/i would the safest bet. Also don't forget to escape 
>>> double quotes (e.g. "Jonathan \"Jon\" Doe" <jon@example.net>).
>> A-Z and [[:space:]] are OK too.
> 
> The 'i' at the end of the regex means case-insensitive ;) but yes, I 
> forgot whitespace. So something like:
> 
>   if ($name =~ /[^a-z0-9[:space:]]/i) {
>     quote_name;
>   }
> 
>> I skimmed the spec, but nothing jumped out at me.
> 
> My recommendation was mostly based on what pine does. It seems to be a 
> pretty sane MUA...

Better:  Dig out the respective RFCs or/and use a library (perl module
or whatever) for the recoding into mail header formats.
-- 
Stefan Richter
-=====-=-=== =--- -===-
http://arcgraph.de/sr/