Re: [PATCH] [2/2many] - FInd the maintainer(s) for a patch - MAINTAINERS

[Joe Perches <joe@perches.com>]

On Mon, 2007-08-13 at 12:36 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Sun, 12 Aug 2007 23:10:16 PDT, Joe Perches said:
> 
> > + A trailing slash includes all files and subdirectory files.
> > + F: drivers/net/ all files in and below drivers/net
> > + F: drivers/net/* all files in drivers/net, but not below
> 
> Since somebody is going to screw up and do it - what are the semantics
> of 'drivers/net' and forgetting the trailing slash?

Looks for a specific file in the patch called drivers/net

> is it silent or noisy (if it's silent, it won't get fixed)

silent

> + F: */net/* all files in "any top level directory"/net
> Does the leading '*' match exactly one level

Yes

> or will it match foo/bar/net/* as

No match, the script counts slashes

+sub file_match_pattern {
+    my ($file, $pattern) = @_;
+    if (substr($pattern, -1) eq "/") {
+       if ($file =~ m@^$pattern@) {
+           return 1;
+       }
+    } else {
+       if ($file =~ m@^$pattern@) {
+           my $s1 = ($file =~ tr@/@@);
+           my $s2 = ($pattern =~ tr@/@@);
+           if ($s1 == $s2) {
+               return 1;
+           }
+       }
+    }
+    return 0;
+}

Enhancements appreciated.

> Is a construction like 'net/*/netfilter/*' legal?

Yes

cheers,  Joe