Re: SLUB doesn't work with kdump kernel on Cell

[Lucio Correia <ljhc@br.ibm.com>]

On Tue, 2007-08-14 at 19:11 -0700, Christoph Lameter wrote:
> Can you try this patch?

Thanks, Christoph

It worked fine, both for normal kernel and for dump kernel on Cell. Is
this patch intended to go mainline?

> 
> From 74863f472810cb58dc56dde050616581d38f7673 Mon Sep 17 00:00:00 2001
> From: Christoph Lameter <christoph@qirst.com>
> Date: Tue, 14 Aug 2007 19:09:00 -0700
> Subject: [PATCH] SLUB: Do not fail on broken memory configurations
> 
> Print a big fat warning and do what is necessary to continue if a node
> is marked as up but allocations from the node do not succeed.
> 
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> ---
>  mm/slub.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/slub.c b/mm/slub.c
> index 1488e71..fc82751 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -1877,9 +1877,16 @@ static struct kmem_cache_node * __init early_kmem_cache_node_alloc(gfp_t gfpflag
>  
>  	BUG_ON(kmalloc_caches->size < sizeof(struct kmem_cache_node));
>  
> -	page = new_slab(kmalloc_caches, gfpflags | GFP_THISNODE, node);
> -
> +	page = new_slab(kmalloc_caches, gfpflags, node);
>  	BUG_ON(!page);
> +
> +	if (page_to_nid(page) != node) {
> +		printk(KERN_ERR "SLUB: Unable to allocate memory from "
> +				"node %d\n", node);
> +		printk(KERN_ERR "SLUB: Allocating a useless per node structure"
> +				" in order to be able to continue\n");
> +	}
> +
>  	n = page->freelist;
>  	BUG_ON(!n);
>  	page->freelist = get_freepointer(kmalloc_caches, n);


-- 
Lucio Correia
Software Engineer
IBM LTC Brazil