public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Renninger <trenn@suse.de>
To: "Luck, Tony" <tony.luck@intel.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	Adrian Bunk <bunk@stusta.de>, Sam Ravnborg <sam@ravnborg.org>,
	Jan Dittmer <jdi@l4x.org>, Len Brown <lenb@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-ia64@vger.kernel.org
Subject: RE: scripts/mod/file2alias.c cross compile problem
Date: Thu, 16 Aug 2007 19:03:37 +0200	[thread overview]
Message-ID: <1187283817.8780.837.camel@queen.suse.de> (raw)
In-Reply-To: <617E1C2C70743745A92448908E030B2A022DBC43@scsmsx411.amr.corp.intel.com>

On Thu, 2007-08-16 at 09:26 -0700, Luck, Tony wrote:
> > -#define ACPI_ID_LEN	9
> > +#define ACPI_ID_LEN	16 /* only 9 bytes needed here, 16 bytes are used */
> 
> What will happen if someone uses more than 9 bytes?  With the old
> limit there would be a compile time error it someone initialized
> with:
> 
> 	{"PNP0C0ABCDEFGH", 0},
> 
> But if we change ACPI_ID_LEN the error will move to run-time.

That should not harm.
>From spec point of view only 8 bytes are needed. Here 9 bytes are used
as then string functions can be used. The whole rest of the kernel does
not use ACPI_ID_LEN.
If someone defines such an id, his driver won't ever get loaded and he
gets bug reports very soon anyway.

Hmm, I wonder whether this even may come in handy later:
Some BIOSes have some spec violating strange hids like:
"*PNP0C0A"
or
"_PNP0C0A"
While I thought the "_" or "*" should be cut away by ACPI parser, it
might be a hint to the OS to do something special. AFAIK only very
specific devices (WMI and some graphics?) have such strange hids
defined, those drivers could explicitly match for the spec violating
string then.

   Thomas


      reply	other threads:[~2007-08-16 17:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070727230741.GD15129@stusta.de>
     [not found] ` <617E1C2C70743745A92448908E030B2A0209BB9D@scsmsx411.amr.corp.intel.com>
2007-07-28  1:39   ` scripts/mod/file2alias.c cross compile problem Adrian Bunk
2007-08-02 15:09     ` Thomas Renninger
2007-08-02 16:25       ` Luck, Tony
2007-08-02 16:36         ` Andreas Schwab
2007-08-02 17:40           ` Luck, Tony
2007-08-02 18:09             ` Sam Ravnborg
2007-08-02 19:15               ` Adrian Bunk
2007-08-02 19:24                 ` Sam Ravnborg
2007-08-02 19:39                   ` Al Viro
2007-08-02 22:08         ` Rusty Russell
2007-08-02 23:03           ` Adrian Bunk
2007-08-16 14:27           ` Thomas Renninger
2007-08-16 16:26             ` Luck, Tony
2007-08-16 17:03               ` Thomas Renninger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187283817.8780.837.camel@queen.suse.de \
    --to=trenn@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bunk@stusta.de \
    --cc=jdi@l4x.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ia64@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=sam@ravnborg.org \
    --cc=tony.luck@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox