From: Glauber de Oliveira Costa <gcosta@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: ak@suse.de, akpm@linux-foundation.org, rusty@rustycorp.com.au,
lguest@ozlabs.org, Glauber de Oliveira Costa <gcosta@redhat.com>
Subject: [PATCH] turn err into errx in lguest call sites
Date: Tue, 21 Aug 2007 17:28:37 -0300 [thread overview]
Message-ID: <1187728117715-git-send-email-gcosta@redhat.com> (raw)
These two callsites should really be errx instead of err, since there is
no errno associated with them in the moment they are issued.
Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
---
Documentation/lguest/lguest.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/lguest/lguest.c b/Documentation/lguest/lguest.c
index f791840..c9d41e9 100644
--- a/Documentation/lguest/lguest.c
+++ b/Documentation/lguest/lguest.c
@@ -159,7 +159,7 @@ static unsigned long entry_point(void *start, void *end,
if (memcmp(p, "GenuineLguest", strlen("GenuineLguest")) == 0)
return (long)p + strlen("GenuineLguest") + page_offset;
- err(1, "Is this image a genuine lguest?");
+ errx(1, "Is this image a genuine lguest?");
}
/* This routine takes an open vmlinux image, which is in ELF, and maps it into
@@ -858,7 +858,7 @@ static u32 handle_block_output(int fd, const struct iovec *iov,
/* We first check that the read or write is within the length of the
* block file. */
if (off >= device_len)
- err(1, "Bad offset %llu vs %llu", off, device_len);
+ errx(1, "Bad offset %llu vs %llu", off, device_len);
/* Move to the right location in the block file. This shouldn't fail,
* but best to check. */
if (lseek64(dev->fd, off, SEEK_SET) != off)
--
1.5.2.2
next reply other threads:[~2007-08-21 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-21 20:28 Glauber de Oliveira Costa [this message]
2007-08-22 6:51 ` [Lguest] [PATCH] turn err into errx in lguest call sites Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187728117715-git-send-email-gcosta@redhat.com \
--to=gcosta@redhat.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustycorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox