* [PATCH] turn err into errx in lguest call sites
@ 2007-08-21 20:28 Glauber de Oliveira Costa
2007-08-22 6:51 ` [Lguest] " Rusty Russell
0 siblings, 1 reply; 2+ messages in thread
From: Glauber de Oliveira Costa @ 2007-08-21 20:28 UTC (permalink / raw)
To: linux-kernel; +Cc: ak, akpm, rusty, lguest, Glauber de Oliveira Costa
These two callsites should really be errx instead of err, since there is
no errno associated with them in the moment they are issued.
Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
---
Documentation/lguest/lguest.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/lguest/lguest.c b/Documentation/lguest/lguest.c
index f791840..c9d41e9 100644
--- a/Documentation/lguest/lguest.c
+++ b/Documentation/lguest/lguest.c
@@ -159,7 +159,7 @@ static unsigned long entry_point(void *start, void *end,
if (memcmp(p, "GenuineLguest", strlen("GenuineLguest")) == 0)
return (long)p + strlen("GenuineLguest") + page_offset;
- err(1, "Is this image a genuine lguest?");
+ errx(1, "Is this image a genuine lguest?");
}
/* This routine takes an open vmlinux image, which is in ELF, and maps it into
@@ -858,7 +858,7 @@ static u32 handle_block_output(int fd, const struct iovec *iov,
/* We first check that the read or write is within the length of the
* block file. */
if (off >= device_len)
- err(1, "Bad offset %llu vs %llu", off, device_len);
+ errx(1, "Bad offset %llu vs %llu", off, device_len);
/* Move to the right location in the block file. This shouldn't fail,
* but best to check. */
if (lseek64(dev->fd, off, SEEK_SET) != off)
--
1.5.2.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Lguest] [PATCH] turn err into errx in lguest call sites
2007-08-21 20:28 [PATCH] turn err into errx in lguest call sites Glauber de Oliveira Costa
@ 2007-08-22 6:51 ` Rusty Russell
0 siblings, 0 replies; 2+ messages in thread
From: Rusty Russell @ 2007-08-22 6:51 UTC (permalink / raw)
To: Glauber de Oliveira Costa; +Cc: linux-kernel, rusty, akpm, ak, lguest
On Tue, 2007-08-21 at 17:28 -0300, Glauber de Oliveira Costa wrote:
> These two callsites should really be errx instead of err, since there is
> no errno associated with them in the moment they are issued.
>
> Signed-off-by: Glauber de Oliveira Costa <gcosta@redhat.com>
Thanks, applied!
Rusty.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-22 6:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-21 20:28 [PATCH] turn err into errx in lguest call sites Glauber de Oliveira Costa
2007-08-22 6:51 ` [Lguest] " Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox