public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, mtk-manpages@gmx.net
Subject: Re: [PATCH] Reset current->pdeath_signal on SUID binary execution
Date: Thu, 23 Aug 2007 10:21:11 +0200	[thread overview]
Message-ID: <1187857271.15402.20.camel@violet> (raw)
In-Reply-To: <1187380078.6698.448.camel@violet>

Hi,

> the attached patch fixes a flaw in the "parent process death signal"
> when executing SUID binaries. An unprivileged user may send arbitrary
> signal to a child process even if it is running with higher privileges.
> 
> The idea to fix this issue is to reset pdeath_signal not only on fork,
> but also on the execution of a SUID binary.
> 
> Michael, if we fix it this way, then the prctl() manual page should
> reflect that behavior.

the patch has been merged into 2.4 and 2.6, so the manual page needs an
update at some point.

> From comments it seems that we have to also reset pdeath_signal inside
> LSM when it comes to capability-raised executes, but I must admit that I
> got lost there.

No further comments for this one? I am not familiar enough with it.

Regards

Marcel



  reply	other threads:[~2007-08-23  8:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-17 19:47 [PATCH] Reset current->pdeath_signal on SUID binary execution Marcel Holtmann
2007-08-23  8:21 ` Marcel Holtmann [this message]
2007-08-27 15:32   ` Michael Kerrisk
2007-08-27 16:28     ` Linus Torvalds
2012-04-23  9:34 ` Michael Kerrisk (man-pages)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187857271.15402.20.camel@violet \
    --to=marcel@holtmann.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk-manpages@gmx.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox