From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: Satyam Sharma <satyam@infradead.org>
Cc: Gerald Schaefer <gerald.schaefer@de.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] s390 appldata_base: Remove module_exit function and modular stuff
Date: Thu, 23 Aug 2007 13:01:06 +0200 [thread overview]
Message-ID: <1187866866.6599.6.camel@localhost> (raw)
In-Reply-To: <alpine.LFD.0.999.0708230746450.2049@enigma.security.iitk.ac.in>
On Thu, 2007-08-23 at 07:51 +0530, Satyam Sharma wrote:
> > BTW the __exit module_exit function appldata_exit() of this driver
> > fails to unregister_hotcpu_notifier() the notifier_block that was
> > registered by appldata_init() during module startup. This will lead
> > to oops if hotplug notification comes after module has been unloaded.
> > Let's fix this by unregistering the notifier appropriately (before
> > appldata_offline_cpu()'ing the CPUs).
>
> Heh, no wonder we never saw this oops before. This code can never be
> built as a module! :-) But why does it define and implement an __exit
> marked module_exit(appldata_exit) function in that case ?!
I has been a module once for debugging purposes That the module_exit
function still exists is "historical". We can remove it since it is dead
code.
--
blue skies,
Martin.
"Reality continues to ruin my life." - Calvin.
next prev parent reply other threads:[~2007-08-23 10:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LFD.0.999.0708230706570.2049@enigma.security.iitk.ac.in >
2007-08-23 1:38 ` [PATCH] s390 appldata_base: Misc cpuinit annotations and bugfix Satyam Sharma
2007-08-23 2:21 ` [PATCH] s390 appldata_base: Remove module_exit function and modular stuff Satyam Sharma
2007-08-23 11:01 ` Martin Schwidefsky [this message]
2007-08-23 22:51 ` Satyam Sharma
2007-08-24 7:37 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187866866.6599.6.camel@localhost \
--to=schwidefsky@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=gerald.schaefer@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=satyam@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox