public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Michael Smith <msmith@xiph.org>
Cc: linux-kernel@vger.kernel.org, Andy Wingo <wingo@fluendo.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	john stultz <johnstul@us.ibm.com>
Subject: Re: gettimeofday() jumping into the future
Date: Thu, 23 Aug 2007 13:47:12 +0200	[thread overview]
Message-ID: <1187869632.6114.368.camel@twins> (raw)
In-Reply-To: <3c1737210708230408i7a8049a9m5db49e6c4d89ab62@mail.gmail.com>

[ CCs added ]

On Thu, 2007-08-23 at 13:08 +0200, Michael Smith wrote:
> Hi,
> 
> We've been seeing some strange behaviour on some of our applications
> recently. I've tracked this down to gettimeofday() returning spurious
> values occasionally.
> 
> Specifically, gettimeofday() will suddenly, for a single call, return
> a value about 4398 seconds (~1 hour 13 minutes) in the future. The
> following call goes back to a normal value.
> 
> This seems to be occurring when the clock source goes slightly
> backwards for a single call. In
> kernel/time/timekeeping.c:__get_nsec_offset(), we have this:
>  cycle_delta = (cycle_now - clock->cycle_last) & clock->mask;
> 
> So a small decrease in time here will (this is all unsigned
> arithmetic) give us a very large cycle_delta. cyc2ns() then multiplies
> this by some value, then right shifts by 22. The resulting value (in
> nanoseconds) is approximately 4398 seconds; this gets added on to the
> xtime value, giving us our jump into the future. The next call to
> gettimeofday() returns to normal as we don't have this huge nanosecond
> offset.
> 
> This system is a 2-socket core 2 quad machine (8 cpus), running 32 bit
> mode. It's a dell poweredge 1950. The kernel selects the TSC as the
> clock source, having determined that the tsc runs synchronously on
> this system. Switching the systems to use a different time source
> seems to make the problem go away (which is fine for us, but we'd like
> to get this fixed properly upstream).
> 
> We've also seen this behaviour with a synthetic test program (which
> just runs 4 threads all calling gettimeofday() in a loop as fast as
> possible and testing that it doesn't jump) on an older machine, a dell
> poweredge SC1425 with two p4 hyperthreaded xeons.
> 
> Can anyone advise on what's going wrong here? I can't find much in the
> way of documentation on whether the TSC is guaranteed to be
> monotonically increasing on intel systems. Should the code choose not
> to use the TSC? Or should the TSC reading code ensure that the
> returned values are monotonic?
> 
> Is there any more information that would be useful? I'll be on a plane
> for most of tomorrow, so might be a little slow responding.

The exact version of the kernel you're using might be good thing to
start with :-)



  parent reply	other threads:[~2007-08-23 11:47 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-23 11:08 gettimeofday() jumping into the future Michael Smith
2007-08-23 11:36 ` Gerald Britton
2007-08-23 13:03   ` Avi Kivity
2007-08-23 20:09     ` H. Peter Anvin
2007-08-23 20:07   ` H. Peter Anvin
2007-08-23 11:47 ` Peter Zijlstra [this message]
2007-08-23 12:20   ` Michael Smith
2007-08-23 18:47     ` john stultz
2007-08-25 16:44       ` Michael Smith
2008-03-30 21:17 ` Tim Ricketts
2008-03-31  7:18   ` Andi Kleen
2008-04-03 11:47     ` James Courtier-Dutton
2008-04-03 12:22       ` James Courtier-Dutton
2008-04-03 12:44         ` James Courtier-Dutton
2008-04-11 23:11           ` john stultz
2008-03-31  8:55   ` Thomas Gleixner
2008-03-31 16:03     ` John Stultz
2008-04-02 11:22       ` Thomas Gleixner
2008-04-02 23:57         ` Karsten Wiese
2008-04-03  6:28           ` Thomas Gleixner
2008-04-02  4:26   ` Mihai Donțu
2008-04-02  4:27     ` Mihai Donțu
     [not found] <47F3F313.7030803@vmware.com>
2008-04-02 22:40 ` Tim Mann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1187869632.6114.368.camel@twins \
    --to=peterz@infradead.org \
    --cc=johnstul@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=msmith@xiph.org \
    --cc=tglx@linutronix.de \
    --cc=wingo@fluendo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox