From: Chandra Seetharaman <sekharan@us.ibm.com>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Martin Michlmayr <tbm@cyrius.com>,
Mike Christie <michaelc@cs.wisc.edu>,
linux-kernel@vger.kernel.org
Subject: Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
Date: Fri, 24 Aug 2007 15:16:27 -0700 [thread overview]
Message-ID: <1187993787.17399.343.camel@linuxchandra> (raw)
In-Reply-To: <20070824150021.a7fdc9f6.randy.dunlap@oracle.com>
On Fri, 2007-08-24 at 15:00 -0700, Randy Dunlap wrote:
> On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:
>
> > It does, but "rdac" _is_ for a SCSI device.
>
> It does __what__ ? depend on SCSI?
Yes, as you understood it correctly :)
> I don't see that in drivers/md/Kconfig.
> Sounds like Martin is correct, SCSI needs to be added, like below.
I do agree that the following patch would be needed.
Since the rdac hardware handler is for a scsi device, including it
without SCSI would not achieve anything (as his device won't be visible
in the first place). Hence my question.
For completeness, I agree that we need the fix pointed below.
>
>
> > What device are you using it with ?
> >
> > On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
> > > I just got:
> > >
> > > Building modules, stage 2.
> > > MODPOST 414 modules
> > > ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
> > > make[1]: *** [__modpost] Error 1
> > >
> > > Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
> > > here) since it uses scsi_normalize_sense.
>
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
> so add SCSI to its depends on to prevent build errors.
>
> Not tested.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/md/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc3-git6.orig/drivers/md/Kconfig
> +++ linux-2.6.23-rc3-git6/drivers/md/Kconfig
> @@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
>
> config DM_MULTIPATH_RDAC
> tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
> - depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
> + depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
> ---help---
> Multipath support for LSI/Engenio RDAC.
>
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@us.ibm.com | .......you may get it.
----------------------------------------------------------------------
next prev parent reply other threads:[~2007-08-24 22:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 16:08 DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined Martin Michlmayr
2007-08-24 21:33 ` Chandra Seetharaman
2007-08-24 22:00 ` Randy Dunlap
2007-08-24 22:16 ` Chandra Seetharaman [this message]
2007-08-25 8:04 ` Martin Michlmayr
2007-08-25 7:51 ` Martin Michlmayr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187993787.17399.343.camel@linuxchandra \
--to=sekharan@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=randy.dunlap@oracle.com \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox