* DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
@ 2007-08-24 16:08 Martin Michlmayr
2007-08-24 21:33 ` Chandra Seetharaman
0 siblings, 1 reply; 6+ messages in thread
From: Martin Michlmayr @ 2007-08-24 16:08 UTC (permalink / raw)
To: Mike Christie; +Cc: Chandra Seetharaman, linux-kernel
I just got:
Building modules, stage 2.
MODPOST 414 modules
ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
make[1]: *** [__modpost] Error 1
Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
here) since it uses scsi_normalize_sense.
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
2007-08-24 16:08 DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined Martin Michlmayr
@ 2007-08-24 21:33 ` Chandra Seetharaman
2007-08-24 22:00 ` Randy Dunlap
2007-08-25 7:51 ` Martin Michlmayr
0 siblings, 2 replies; 6+ messages in thread
From: Chandra Seetharaman @ 2007-08-24 21:33 UTC (permalink / raw)
To: Martin Michlmayr; +Cc: Mike Christie, linux-kernel
It does, but "rdac" _is_ for a SCSI device.
What device are you using it with ?
On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
> I just got:
>
> Building modules, stage 2.
> MODPOST 414 modules
> ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
> make[1]: *** [__modpost] Error 1
>
> Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
> here) since it uses scsi_normalize_sense.
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@us.ibm.com | .......you may get it.
----------------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
2007-08-24 21:33 ` Chandra Seetharaman
@ 2007-08-24 22:00 ` Randy Dunlap
2007-08-24 22:16 ` Chandra Seetharaman
2007-08-25 8:04 ` Martin Michlmayr
2007-08-25 7:51 ` Martin Michlmayr
1 sibling, 2 replies; 6+ messages in thread
From: Randy Dunlap @ 2007-08-24 22:00 UTC (permalink / raw)
To: sekharan; +Cc: Martin Michlmayr, Mike Christie, linux-kernel
On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:
> It does, but "rdac" _is_ for a SCSI device.
It does __what__ ? depend on SCSI?
I don't see that in drivers/md/Kconfig.
Sounds like Martin is correct, SCSI needs to be added, like below.
> What device are you using it with ?
>
> On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
> > I just got:
> >
> > Building modules, stage 2.
> > MODPOST 414 modules
> > ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> >
> > Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
> > here) since it uses scsi_normalize_sense.
---
From: Randy Dunlap <randy.dunlap@oracle.com>
DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
so add SCSI to its depends on to prevent build errors.
Not tested.
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
drivers/md/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.23-rc3-git6.orig/drivers/md/Kconfig
+++ linux-2.6.23-rc3-git6/drivers/md/Kconfig
@@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
config DM_MULTIPATH_RDAC
tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
- depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
+ depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
---help---
Multipath support for LSI/Engenio RDAC.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
2007-08-24 22:00 ` Randy Dunlap
@ 2007-08-24 22:16 ` Chandra Seetharaman
2007-08-25 8:04 ` Martin Michlmayr
1 sibling, 0 replies; 6+ messages in thread
From: Chandra Seetharaman @ 2007-08-24 22:16 UTC (permalink / raw)
To: Randy Dunlap; +Cc: Martin Michlmayr, Mike Christie, linux-kernel
On Fri, 2007-08-24 at 15:00 -0700, Randy Dunlap wrote:
> On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:
>
> > It does, but "rdac" _is_ for a SCSI device.
>
> It does __what__ ? depend on SCSI?
Yes, as you understood it correctly :)
> I don't see that in drivers/md/Kconfig.
> Sounds like Martin is correct, SCSI needs to be added, like below.
I do agree that the following patch would be needed.
Since the rdac hardware handler is for a scsi device, including it
without SCSI would not achieve anything (as his device won't be visible
in the first place). Hence my question.
For completeness, I agree that we need the fix pointed below.
>
>
> > What device are you using it with ?
> >
> > On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
> > > I just got:
> > >
> > > Building modules, stage 2.
> > > MODPOST 414 modules
> > > ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
> > > make[1]: *** [__modpost] Error 1
> > >
> > > Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
> > > here) since it uses scsi_normalize_sense.
>
> ---
>
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
> so add SCSI to its depends on to prevent build errors.
>
> Not tested.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
> drivers/md/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc3-git6.orig/drivers/md/Kconfig
> +++ linux-2.6.23-rc3-git6/drivers/md/Kconfig
> @@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
>
> config DM_MULTIPATH_RDAC
> tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
> - depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
> + depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
> ---help---
> Multipath support for LSI/Engenio RDAC.
>
--
----------------------------------------------------------------------
Chandra Seetharaman | Be careful what you choose....
- sekharan@us.ibm.com | .......you may get it.
----------------------------------------------------------------------
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
2007-08-24 21:33 ` Chandra Seetharaman
2007-08-24 22:00 ` Randy Dunlap
@ 2007-08-25 7:51 ` Martin Michlmayr
1 sibling, 0 replies; 6+ messages in thread
From: Martin Michlmayr @ 2007-08-25 7:51 UTC (permalink / raw)
To: Chandra Seetharaman; +Cc: Mike Christie, linux-kernel
* Chandra Seetharaman <sekharan@us.ibm.com> [2007-08-24 14:33]:
> It does, but "rdac" _is_ for a SCSI device.
>
> What device are you using it with ?
I'm not using it at all. I merely compiled a kernel where
DM_MULTIPATH_RDAC was activated by chance without SCSI. Randy's patch
looks good.
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined
2007-08-24 22:00 ` Randy Dunlap
2007-08-24 22:16 ` Chandra Seetharaman
@ 2007-08-25 8:04 ` Martin Michlmayr
1 sibling, 0 replies; 6+ messages in thread
From: Martin Michlmayr @ 2007-08-25 8:04 UTC (permalink / raw)
To: sekharan, Mike Christie, linux-kernel, randy.dunlap
* Randy Dunlap <randy.dunlap@oracle.com> [2007-08-24 15:00]:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
> so add SCSI to its depends on to prevent build errors.
>
> Not tested.
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Tested-by: Martin Michlmayr <tbm@cyrius.com>
This works for me. Please make sure it'll go into 2.6.23.
--
Martin Michlmayr
http://www.cyrius.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-08-25 8:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-24 16:08 DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined Martin Michlmayr
2007-08-24 21:33 ` Chandra Seetharaman
2007-08-24 22:00 ` Randy Dunlap
2007-08-24 22:16 ` Chandra Seetharaman
2007-08-25 8:04 ` Martin Michlmayr
2007-08-25 7:51 ` Martin Michlmayr
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox