From: Ram Pai <linuxram@us.ibm.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
Andrew Morton <akpm@linux-foundation.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: [2.6 patch] fix export_report.pl on top of adrian's fix
Date: Fri, 24 Aug 2007 15:32:22 -0700 [thread overview]
Message-ID: <1187994742.2910.29.camel@ram.us.ibm.com> (raw)
In-Reply-To: <20070824214743.GH30705@stusta.de>
Fixes some subtle perl coding bug observed
by Jan Engelhardt <jengelh@computergmbh.de>
This patch applies on top of Adrian's fix.
Signed-off-by: Ram Pai <linuxram@us.ibm.com>
---
scripts/export_report.pl | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Index: linux-2.6.21.5/scripts/export_report.pl
===================================================================
--- linux-2.6.21.5.orig/scripts/export_report.pl
+++ linux-2.6.21.5/scripts/export_report.pl
@@ -103,15 +103,15 @@ foreach my $thismod (@allcfiles) {
my $state=0;
while ( <MODULE_MODULE> ) {
chomp;
- if ($state eq 0) {
+ if ($state == 0) {
$state = 1 if ($_ =~ /static const struct modversion_info/);
next;
}
- if ($state eq 1) {
+ if ($state == 1) {
$state = 2 if ($_ =~ /__attribute__\(\(section\("__versions"\)\)\)/);
next;
}
- if ($state eq 2) {
+ if ($state == 2) {
if ( $_ !~ /0x[0-9a-f]+,/ ) {
next;
}
@@ -121,7 +121,7 @@ foreach my $thismod (@allcfiles) {
push(@{$MODULE{$thismod}} , $sym);
}
}
- if ($state ne 2) {
+ if ($state != 2) {
print "WARNING:$thismod is not built with CONFIG_MODVERSION enabled\n";
}
close(MODULE_MODULE);
next prev parent reply other threads:[~2007-08-24 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 21:04 [2.6 patch] fix export_report.pl Adrian Bunk
2007-08-24 21:36 ` Jan Engelhardt
2007-08-24 21:47 ` Adrian Bunk
2007-08-24 22:32 ` Ram Pai [this message]
2007-08-24 21:40 ` Ram Pai
2007-08-25 10:51 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1187994742.2910.29.camel@ram.us.ibm.com \
--to=linuxram@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=bunk@kernel.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox