From: Matt Colyer <matt@colyer.name>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>, Oliver Neukum <oliver@neukum.org>,
linux-kernel@vger.kernel.org, jeffm@suse.de,
linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] [RFC] USB: driver for iphone charging
Date: Fri, 24 Aug 2007 19:21:55 -0700 [thread overview]
Message-ID: <1188008516.14761.7.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0708241449520.22079-100000@iolanthe.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 1564 bytes --]
On Fri, 2007-08-24 at 14:55 -0400, Alan Stern wrote:
> On Fri, 24 Aug 2007, Greg KH wrote:
>
> > Can someone with a iphone test this out? If you look at how the
> > berry_charge driver does it, the set_config stuff happens after the
> > magic command. As I don't have an iphone, nor have I ever seen any
> > dumps of the command streams, I don't really know if the set_config
> > message really is necessary or not.
>
> You know, now that I think back on it, it may be that the Set-Config
> really does have to come after the magic command. Perhaps it triggers
> the changeover. In which case the subroutine should look like this:
>
Hi all,
I was the one who wrote the patch initially (sorry I haven't been able
to chime in sooner). It turns out that the configuration must be set
after the magic command (I tried both versions of the code tonight and
only the one which changes the configuration after the command works).
That said, I am not opposed to using a userspace program to accomplish
this task (I tried to pursue that avenue at first and couldn't find a
way to do, probably because it doesn't exist yet). I don't really have
much experience in this area, so I am not really sure how to proceed.
However the other part of this puzzle is that when you call lsusb the
iPhone disconnects from the bus. Greg suggested that it might be an
issue with the USB_SUSPEND support being broken on the iPhone and he
suggested I tried adding it to the quirks.c file. I'll be sure to let
you guys know when I figure it out.
-Matt
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-08-25 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 22:45 [RFC] USB: driver for iphone charging Greg KH
2007-08-24 7:20 ` Oliver Neukum
2007-08-24 14:08 ` [linux-usb-devel] " Alan Stern
2007-08-24 14:23 ` Oliver Neukum
2007-08-24 18:36 ` Greg KH
2007-08-24 18:35 ` Greg KH
2007-08-24 18:55 ` Alan Stern
2007-08-25 2:21 ` Matt Colyer [this message]
[not found] <8VtFd-7mx-51@gated-at.bofh.it>
2007-08-24 10:51 ` Bodo Eggert
2007-08-24 18:33 ` [linux-usb-devel] " Greg KH
2007-08-25 8:51 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188008516.14761.7.camel@localhost \
--to=matt@colyer.name \
--cc=greg@kroah.com \
--cc=jeffm@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox