From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Andrew Morton <akpm@osdl.org>,
William Lee Irwin <wli@holomorphy.com>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org
Subject: Re: hugepage: Fix broken check for offset alignment in hugepage mappings
Date: Mon, 27 Aug 2007 08:05:40 +0200 [thread overview]
Message-ID: <1188194740.5972.52.camel@localhost.localdomain> (raw)
In-Reply-To: <20070827043627.GA7306@localhost.localdomain>
On Mon, 2007-08-27 at 14:36 +1000, David Gibson wrote:
> This patch restores the check, removing it from
> prepare_hugepage_range() and putting it back into
> hugetlbfs_file_mmap(). I'm putting it there, rather than in the
> get_unmapped_area() path so it only needs to go in one place, than
> separately in the half-dozen or so arch-specific implementations of
> hugetlb_get_unmapped_area().
Yup, that's the right place to put it imho.
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
prev parent reply other threads:[~2007-08-27 6:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 4:36 hugepage: Fix broken check for offset alignment in hugepage mappings David Gibson
2007-08-27 6:05 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1188194740.5972.52.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox