Re: [PATCH] Fix: tracepoint: use after rcu free

[Mathieu Desnoyers <mathieu.desnoyers@efficios.com>]

----- Original Message -----
> From: "Steven Rostedt" <rostedt@goodmis.org>
> To: "Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>
> Cc: linux-kernel@vger.kernel.org, "Sasha Levin" <sasha.levin@oracle.com>, "Oleg Nesterov" <oleg@redhat.com>, "Dave
> Jones" <davej@redhat.com>
> Sent: Thursday, May 8, 2014 9:15:29 AM
> Subject: Re: [PATCH] Fix: tracepoint: use after rcu free
> 
> On Thu, 8 May 2014 13:08:25 +0000 (UTC)
> Mathieu Desnoyers <mathieu.desnoyers@efficios.com> wrote:
> 
> > > 
> > > We can also include a (even though it's redundant)
> > > 
> > >  Fixes: de7b2973903c "tracepoint: Use struct pointer instead of name hash
> > >  for
> > >  reg/unreg tracepoints"
> > 
> > Thanks for the pointers, I'll keep those in mind for my next patches.
> 
> Oh, one more thing I keep forgetting to mention to you. Your subject
> lines :-)
> 
> I converted it to be:
> 
>  tracepoint: Fix use of tracepoint funcs after rcu free
> 
> only the subsystem tag should be used. Not a "Fix" tag. But the "Fix"
> may be used in the subject itself. Also, I've been told that Linus
> prefers to have the subject written more like a sentence and the first
> character capitalized.

OK, I'm taking notes for next time.

Thanks!

Mathieu

> 
> -- Steve
> 

-- 
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com