Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding

Rob Herring
2018-12-11T22:11:30Z

On Tue, Nov 27, 2018 at 03:42:49PM +0800, Icenowy Zheng wrote:
> Allwinner H6 SoC uses a Mali T720 GPU, which is one of the GPUs in the
> Midgard GPU product line.
>
> Add binding for the H6 Mali Midgard GPU.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
> .../devicetree/bindings/gpu/arm,mali-midgard.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> index 02f870cd60e6..c897dd7be48f 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt
> @@ -18,6 +18,7 @@ Required properties:
> + "amlogic,meson-gxm-mali"
> + "rockchip,rk3288-mali"
> + "rockchip,rk3399-mali"
> + + "allwinner,sun50i-h6-mali"
>
> - reg : Physical base address of the device and length of the register area.
>
> @@ -44,6 +45,18 @@ Optional properties:
> for details.
>
>
> +Vendor-specific bindings
> +------------------------
> +
> +The Mali GPU is integrated very differently from one SoC to
> +another. In order to accomodate those differences, you have the option

WARNING: 'accomodate' may be misspelled - perhaps 'accommodate'?
#50: FILE: Documentation/devicetree/bindings/gpu/arm,mali-midgard.txt:52:

> +to specify one more vendor-specific compatible, among:
> +
> + - allwinner,sun50i-h6-mali
> + Required properties:
> + * resets: phandle to the reset line for the GPU
> +
> +
> Example for a Mali-T760:
>
> gpu@ffa30000 {
> --
> 2.18.1
>