Re: [PATCH 2/2] dt-bindings: gpu: add Allwinner H6 Mali Midgard binding

Maxime Ripard
2018-12-03T12:42:21Z

[-- Attachment #1: Type: text/plain, Size: 1034 bytes --]

On Mon, Dec 03, 2018 at 01:25:21PM +0100, Heiko Stuebner wrote:
> > - reg : Physical base address of the device and length of the register area.
> >
> > @@ -44,6 +45,18 @@ Optional properties:
> > for details.
> >
> >
> > +Vendor-specific bindings
> > +------------------------
> > +
> > +The Mali GPU is integrated very differently from one SoC to
> > +another. In order to accomodate those differences, you have the option
> > +to specify one more vendor-specific compatible, among:
> > +
> > + - allwinner,sun50i-h6-mali
> > + Required properties:
> > + * resets: phandle to the reset line for the GPU
>
> While this paragraph is similar to how it is done in Utgard, I'm
> wondering why we cannot just describe the "resets" as regular
> optional property above that.

Because it's not really optional, it's mandatory on some platforms
(like this one) and has no significance on others.

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]