From: Rusty Russell <rusty@rustcorp.com.au>
To: Glauber de Oliveira Costa <gcosta@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
rostedt@goodmiss.org, virtualization@lists.linux-foundation.org,
lguest@ozlabs.org, glommer@gmail.com
Subject: Re: [PATCH] Add macros for acessing lguest fields
Date: Thu, 13 Sep 2007 16:32:53 +1000 [thread overview]
Message-ID: <1189665173.32322.17.camel@localhost.localdomain> (raw)
In-Reply-To: <11894484404160-git-send-email-gcosta@redhat.com>
On Mon, 2007-09-10 at 15:20 -0300, Glauber de Oliveira Costa wrote:
> The assumption that we have an overall irqs_pending flags,
> and a one-to-one lguest <-> task mapping fails to hold on x86_64,
> where we can have multiple puppies, aka vcpus.
>
> Although ifdefs could be used, it makes the code much more
> unreadable, and other ports are on the way, anyway. So some sort
> of acessor is preferred anyway.
I'd prefer to see the i386 code use vcpus too. Even if i386 only has
one at present, it's cleaner.
Of course, there'll be a lot of "s/lg/vcpu/" churn, but that's OK.
Thanks,
Rusty.
prev parent reply other threads:[~2007-09-13 6:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 18:20 [PATCH] Add macros for acessing lguest fields Glauber de Oliveira Costa
2007-09-13 6:32 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189665173.32322.17.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=gcosta@redhat.com \
--cc=glommer@gmail.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmiss.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox