Re: [GIT PULL] Blackfin arch bug fixing for 2.6.23-rc6

[Bryan Wu <bryan.wu@analog.com>]

On Thu, 2007-09-13 at 08:54 +0200, Jan Dittmer wrote:
> Bryan Wu wrote:
> > Hi Linus,
> > 
> > Please pull from 'for-linus' branch of
> > 
> > master.kernel.org:/pub/scm/linux/kernel/git/cooloney/blackfin-2.6.git for-linus
> > 
> > to receive the following updates:
> > 
> >  arch/blackfin/mach-common/pm.c              |    6 ++
> >  include/asm-blackfin/mach-bf561/cdefBF561.h |    4 +-
> >  include/asm-blackfin/string.h               |  129 +++++++++++++++++----------
> 
> btw. what about this error?
> 
> fs/binfmt_flat.c:760:50: error: macro "flat_get_addr_from_rp" requires 4 
> arguments, but only 3 given
> fs/binfmt_flat.c:760: error: ‘flat_get_addr_from_rp’ undeclared (first use in 
> this function)
> fs/binfmt_flat.c:760: error: (Each undeclared identifier is reported only once
> fs/binfmt_flat.c:760: error: for each function it appears in.)
> make[2]: *** [fs/binfmt_flat.o] Error 1
> make[1]: *** [fs] Error 2
> make: *** [_all] Error 2
> 

Thanks for the testing.

> any chance to get that fixed prior to .23? (not a regression, but
> happens approx. since blackfin was merged)
> 

This is because a binfmt_flat hacking patch for Blackfin arch is not
accept by the mainline. It can be workaround by disabling
CONFIG_BINFMT_FLAT in menuconfig.

Need I disable CONFIG_BINFMT_FLAT in defconfigs for Blackfin to make the
compile pass?

> Full build log: http://l4x.org/k/?d=34032

Thanks again, beautiful log and which defconfigs do you using to do the
test and what's the toolchain version?

Best Regards
-Bryan Wu