From: Peter Zijlstra <peterz@infradead.org>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Mike Galbraith <efault@gmx.de>
Subject: Re: [announce] CFS-devel, performance improvements
Date: Thu, 13 Sep 2007 19:09:42 +0200 [thread overview]
Message-ID: <1189703382.21778.260.camel@twins> (raw)
In-Reply-To: <1189703165.21778.258.camel@twins>
On Thu, 2007-09-13 at 19:06 +0200, Peter Zijlstra wrote:
> On Thu, 2007-09-13 at 18:50 +0200, Roman Zippel wrote:
>
> > I never claimed to understand every detail of CFS, I can _guess_ what
> > _might_ have been intended, but from that it's impossible to know for
> > certain how important they are. Let's take this patch fragment:
> >
>
> delta_fair = se->delta_fair_sleep;
>
> we slept that much
>
> > - /*
> > - * Fix up delta_fair with the effect of us running
> > - * during the whole sleep period:
> > - */
> > - if (sched_feat(SLEEPER_AVG))
> > - delta_fair = div64_likely32((u64)delta_fair * load,
> > - load + se->load.weight);
>
> if we would have ran we would not have been removed from the rq and the
> weight would have been: rq_weight + weight
>
> so compensate for us having been removed from the rq by scaling the
> delta with: rq_weight/(rq_weight + weight)
>
> > - delta_fair = calc_weighted(delta_fair, se);
>
> scale for nice levels
>
Or at least, I think that is how to read it :-)
next prev parent reply other threads:[~2007-09-13 17:10 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 20:04 [announce] CFS-devel, performance improvements Ingo Molnar
2007-09-12 0:42 ` Roman Zippel
2007-09-13 7:52 ` Ingo Molnar
2007-09-13 12:35 ` Roman Zippel
2007-09-13 14:28 ` Ingo Molnar
2007-09-13 16:50 ` Roman Zippel
2007-09-13 17:06 ` Peter Zijlstra
2007-09-13 17:09 ` Peter Zijlstra [this message]
2007-09-14 12:04 ` Roman Zippel
2007-09-14 12:17 ` Peter Zijlstra
2007-09-13 18:28 ` Kyle Moffett
2007-09-13 19:08 ` Peter Zijlstra
2007-09-14 15:26 ` Arjan van de Ven
2007-09-14 14:50 ` Roman Zippel
2007-09-14 15:56 ` Arjan van de Ven
2007-09-14 15:13 ` Roman Zippel
2007-09-13 19:01 ` Sam Ravnborg
2007-09-14 12:26 ` Roman Zippel
2007-09-12 1:16 ` Rob Hussey
2007-09-13 8:42 ` Rob Hussey
2007-09-13 9:06 ` Ingo Molnar
2007-09-13 9:24 ` Rob Hussey
2007-09-13 9:31 ` Ingo Molnar
2007-09-13 9:36 ` Rob Hussey
2007-09-13 9:43 ` Rob Hussey
2007-09-13 10:17 ` Rob Hussey
2007-09-13 11:48 ` Ingo Molnar
2007-09-14 1:47 ` Rob Hussey
2007-09-14 2:26 ` Rob Hussey
2007-09-14 6:59 ` Kyle Moffett
2007-09-12 6:20 ` Mike Galbraith
2007-09-12 22:17 ` Roman Zippel
2007-09-13 7:17 ` debian developer
2007-09-13 7:34 ` debian developer
2007-09-13 9:19 ` Ingo Molnar
2007-09-13 11:35 ` Peter Zijlstra
2007-09-13 12:14 ` Roman Zippel
2007-09-13 12:44 ` Peter Zijlstra
2007-09-14 11:16 ` Peter Zijlstra
2007-09-13 12:47 ` Ingo Molnar
2007-09-14 11:46 ` Roman Zippel
2007-09-13 23:08 ` Willy Tarreau
2007-09-14 13:10 ` Roman Zippel
2007-09-14 17:54 ` Willy Tarreau
-- strict thread matches above, loose matches on Subject: below --
2007-09-13 22:51 dimm
2007-09-14 8:13 ` Ingo Molnar
2007-09-14 8:13 ` Ingo Molnar
2007-09-13 23:25 dimm
2007-09-14 8:17 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189703382.21778.260.camel@twins \
--to=peterz@infradead.org \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox