From: Joe Perches <joe@perches.com>
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: Takashi Iwai <tiwai@suse.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] add consts where appropriate in sound/pci/hda/*
Date: Fri, 14 Sep 2007 11:09:06 -0700 [thread overview]
Message-ID: <1189793347.19708.156.camel@localhost> (raw)
In-Reply-To: <200709141848.06027.vda.linux@googlemail.com>
On Fri, 2007-09-14 at 18:48 +0100, Denys Vlasenko wrote:
> Patch is attached.
The SND_HDA_PRESETS define doesn't seem useful.
It's only used once.
diff -urp linux-2.6.23-rc6/sound/pci/hda/hda_codec.c linux-2.6.23-rc6.bigdata/sound/pci/hda/hda_codec.c
--- linux-2.6.23-rc6/sound/pci/hda/hda_codec.c 2007-07-09 00:32:17.000000000 +0100
+++ linux-2.6.23-rc6.bigdata/sound/pci/hda/hda_codec.c 2007-09-14 18:32:24.000000000 +0100
@@ -57,6 +57,10 @@ static struct hda_vendor_id hda_vendor_i
/* codec presets */
#include "hda_patch.h"
+static const struct hda_codec_preset *const hda_preset_tables[] = {
+ SND_HDA_PRESETS,
+ NULL
+};
diff -urp linux-2.6.23-rc6/sound/pci/hda/hda_patch.h linux-2.6.23-rc6.bigdata/sound/pci/hda/hda_patch.h
--- linux-2.6.23-rc6/sound/pci/hda/hda_patch.h 2007-07-09 00:32:17.000000000 +0100
+++ linux-2.6.23-rc6.bigdata/sound/pci/hda/hda_patch.h 2007-09-14 18:30:17.000000000 +0100
@@ -1,32 +1,30 @@
/*
- * HDA Patches - included by hda_codec.c
+ * HDA Patches
*/
/* Realtek codecs */
-extern struct hda_codec_preset snd_hda_preset_realtek[];
+extern const struct hda_codec_preset snd_hda_preset_realtek[];
/* C-Media codecs */
-extern struct hda_codec_preset snd_hda_preset_cmedia[];
+extern const struct hda_codec_preset snd_hda_preset_cmedia[];
/* Analog Devices codecs */
-extern struct hda_codec_preset snd_hda_preset_analog[];
+extern const struct hda_codec_preset snd_hda_preset_analog[];
/* SigmaTel codecs */
-extern struct hda_codec_preset snd_hda_preset_sigmatel[];
+extern const struct hda_codec_preset snd_hda_preset_sigmatel[];
/* SiLabs 3054/3055 modem codecs */
-extern struct hda_codec_preset snd_hda_preset_si3054[];
+extern const struct hda_codec_preset snd_hda_preset_si3054[];
/* ATI HDMI codecs */
-extern struct hda_codec_preset snd_hda_preset_atihdmi[];
+extern const struct hda_codec_preset snd_hda_preset_atihdmi[];
/* Conexant audio codec */
-extern struct hda_codec_preset snd_hda_preset_conexant[];
+extern const struct hda_codec_preset snd_hda_preset_conexant[];
/* VIA codecs */
-extern struct hda_codec_preset snd_hda_preset_via[];
+extern const struct hda_codec_preset snd_hda_preset_via[];
-static const struct hda_codec_preset *hda_preset_tables[] = {
- snd_hda_preset_realtek,
- snd_hda_preset_cmedia,
- snd_hda_preset_analog,
- snd_hda_preset_sigmatel,
- snd_hda_preset_si3054,
- snd_hda_preset_atihdmi,
- snd_hda_preset_conexant,
- snd_hda_preset_via,
- NULL
-};
+#define SND_HDA_PRESETS \
+ snd_hda_preset_realtek, \
+ snd_hda_preset_cmedia, \
+ snd_hda_preset_analog, \
+ snd_hda_preset_sigmatel, \
+ snd_hda_preset_si3054, \
+ snd_hda_preset_atihdmi, \
+ snd_hda_preset_conexant, \
+ snd_hda_preset_via
next prev parent reply other threads:[~2007-09-14 18:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 17:48 [PATCH] add consts where appropriate in sound/pci/hda/* Denys Vlasenko
2007-09-14 18:09 ` Joe Perches [this message]
2007-09-14 19:34 ` Denys Vlasenko
2007-09-14 22:12 ` Denys Vlasenko
2007-09-15 9:43 ` Jan Engelhardt
2007-09-15 10:18 ` Sam Ravnborg
2007-09-15 10:29 ` Jan Engelhardt
2007-09-15 11:42 ` Denys Vlasenko
2007-09-15 12:40 ` Andreas Schwab
2007-09-15 13:47 ` Denys Vlasenko
2007-09-15 17:42 ` Jan Engelhardt
2007-09-17 10:01 ` Takashi Iwai
2007-09-17 21:53 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189793347.19708.156.camel@localhost \
--to=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox