From: Rusty Russell <rusty@rustcorp.com.au>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: jengelh@gmx.de,
lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
virtualization <virtualization@lists.linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Zachary Amsden <zach@vmware.com>,
Chris Wright <chrisw@sous-sol.org>, Avi Kivity <avi@qumranet.com>,
Anthony Liguori <aliguori@us.ibm.com>
Subject: Re: [PATCH 2/3] Consolidate host virtualization support under Virtualization menu
Date: Sat, 15 Sep 2007 13:05:04 +1000 [thread overview]
Message-ID: <1189825504.7262.75.camel@localhost.localdomain> (raw)
In-Reply-To: <20070914091921.73007c5a.randy.dunlap@oracle.com>
On Fri, 2007-09-14 at 09:19 -0700, Randy Dunlap wrote:
> On Fri, 14 Sep 2007 15:18:44 +1000 Rusty Russell wrote:
>
> > We turn "Virtualization" into a menu, not a config option, since it's
> > actually only used as a menu. Then we move lguest under that menu.
>
> so you want to revert the 2007-july-16 merge that changes
> menu -> menuconfig and makes most of the menus consistent in
> presentation. I'd rather not, but I don't own it.
Ok, I missed that one. To me it seems gratuitous to create a config
option simply to control a menu. However if that is considered the
Right Way, here is the "Just move lguest" variant.
> And Yes, lguest does need to be moved into a better location.
Indeed,
Rusty.
===
Move lguest under the virtualization menu.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r c2893801de2a drivers/Kconfig
--- a/drivers/Kconfig Fri Sep 14 13:24:46 2007 +1000
+++ b/drivers/Kconfig Fri Sep 14 13:24:49 2007 +1000
@@ -87,6 +87,4 @@ source "drivers/kvm/Kconfig"
source "drivers/kvm/Kconfig"
source "drivers/uio/Kconfig"
-
-source "drivers/lguest/Kconfig"
endmenu
diff -r c2893801de2a drivers/kvm/Kconfig
--- a/drivers/kvm/Kconfig Fri Sep 14 13:24:46 2007 +1000
+++ b/drivers/kvm/Kconfig Fri Sep 14 13:32:22 2007 +1000
@@ -45,4 +36,8 @@ config KVM_AMD
Provides support for KVM on AMD processors equipped with the AMD-V
(SVM) extensions.
-endif # VIRTUALIZATION
+# OK, it's a little counter-intuitive to do this, but it puts it neatly under
+# the virtualization menu.
+source drivers/lguest/Kconfig
+
+endif # VIRTUALIZATION
next prev parent reply other threads:[~2007-09-15 3:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-14 5:17 [PATCH 1/3] Normalize config options for guest support Rusty Russell
2007-09-14 5:18 ` [PATCH 2/3] Consolidate host virtualization support under Virtualization menu Rusty Russell
2007-09-14 5:21 ` [PATCH 3/3] Time to make CONFIG_PARAVIRT non-experimental Rusty Russell
2007-09-18 10:57 ` Andi Kleen
2007-09-18 20:04 ` Charles N Wyble
2007-09-18 20:20 ` Andi Kleen
2007-09-18 20:27 ` Charles N Wyble
2007-09-18 20:41 ` Andi Kleen
2007-09-20 15:45 ` Satyam Sharma
2007-09-20 16:09 ` Charles N Wyble
2007-09-20 16:47 ` Satyam Sharma
2007-09-18 21:34 ` Rusty Russell
2007-09-18 21:52 ` Andi Kleen
2007-09-19 1:53 ` Rusty Russell
2007-09-19 3:59 ` Jeremy Fitzhardinge
2007-09-19 10:43 ` Ian Campbell
2007-09-14 16:19 ` [PATCH 2/3] Consolidate host virtualization support under Virtualization menu Randy Dunlap
2007-09-14 20:01 ` Jan Engelhardt
2007-09-15 3:05 ` Rusty Russell [this message]
2007-09-15 8:49 ` Alexey Eremenko
2007-09-16 7:43 ` Rusty Russell
2007-09-16 14:56 ` Jeremy Fitzhardinge
2007-09-17 19:31 ` Zachary Amsden
2007-09-17 23:30 ` Charles N Wyble
2007-09-18 0:18 ` Jeremy Fitzhardinge
2007-09-18 20:11 ` Charles N Wyble
2007-09-19 9:38 ` Alexey Eremenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1189825504.7262.75.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=chrisw@sous-sol.org \
--cc=jengelh@gmx.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox