Re: [PATCH 2/2] ext2: Avoid rec_len overflow with 64KB block size

Andrew Morton
2007-10-18T09:12:23Z

On Thu, 18 Oct 2007 02:03:39 -0700 (PDT) Christoph Lameter <clameter@sgi.com> wrote:

> On Wed, 17 Oct 2007, Andrew Morton wrote:
>
> > b) what happens when an old ext2 driver tries to read and/or write this
> > directory entry? Do we need a compat flag for it?
>
> Old ext2 only supports up to 4k
>
> include/linux/ext2_fs.h:
>
> #define EXT2_MIN_BLOCK_SIZE 1024
> #define EXT2_MAX_BLOCK_SIZE 4096
> #define EXT2_MIN_BLOCK_LOG_SIZE 10
>
> Should fail to mount the volume since the block size is too large.

should, but does it?

box:/usr/src/25> grep MAX_BLOCK_SIZE fs/ext2/*.[ch] include/linux/ext2*
include/linux/ext2_fs.h:#define EXT2_MAX_BLOCK_SIZE 4096
box:/usr/src/25>