Re: 2.6.23-rc6-mm1

David Brownell
2007-09-20T16:16:01Z

On Thursday 20 September 2007, Kay Sievers wrote:
>
> Isn't that all caused by the rtc driver registering itself without
> checking if it is able to grab the device? Wouldn't moving the
> request_resource() before doing any device registration do the magic?

I suspect it would. Got patch?

I'm trying to remember why it registers before grabbing resources
(I/O region, irq) ... which is not the usual pattern, and is somewhat
of a surprise every time I notice it. Though everything's undone on
error, so it "should" work just fine.

If that's not just some debugging leftover, the only thing that comes
to mind is that maybe it was to ensure that the resource labels in
/proc/{interrupts,ioports} clearly distinguished this from the legacy
driver. The now-conventional way to label things there is by using
a logical name like "rtc0", which is the output of registration.

- Dave