Re: 2.6.23-rc6-mm1 - make access to tasks nsproxy ligther (fix)

Cedric Le Goater
2007-09-20T09:14:13Z

Pavel Emelyanov wrote:
> Looks sane :)
>
> [snip]
>
>> Index: 2.6.23-rc6-mm1/kernel/exit.c
>> ===================================================================
>> --- 2.6.23-rc6-mm1.orig/kernel/exit.c
>> +++ 2.6.23-rc6-mm1/kernel/exit.c
>> @@ -408,6 +408,8 @@ void daemonize(const char *name, ...)
>> current->fs = fs;
>> atomic_inc(&fs->count);
>>
>> + if (current->nsproxy != init_task.nsproxy)
>> + get_nsproxy(init_task.nsproxy);
>> switch_task_namespaces(current, init_task.nsproxy);
>
> shouldn't we make the switch under this if() as well?

right. we can probably simplify switch_task_namespaces() and remove :

if (ns == new)
return;

I'll cook a better one today.

Thanks !

C.