From: "Michael Chan" <mchan@broadcom.com>
To: "Denys Vlasenko" <vda.linux@googlemail.com>
Cc: "David Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org, "netdev" <netdev@vger.kernel.org>
Subject: Re: bnx2 dirver's firmware images
Date: Thu, 20 Sep 2007 19:12:33 -0700 [thread overview]
Message-ID: <1190340753.6934.25.camel@dell> (raw)
In-Reply-To: <200709201549.08165.vda.linux@googlemail.com>
On Thu, 2007-09-20 at 15:49 +0100, Denys Vlasenko wrote:
>
>
> Please test these two patches.
> I updated them according to your comments.
>
>
I've only tested patch #1. It worked after some minor modifications
below.
>
>
>
>
>
> plain text
> document
> attachment
> (linux-2.6.23-
> rc6.bnx2-1.patch)
>
>
> @@ -2767,89 +2769,44 @@ bnx2_set_rx_mode(struct net_device *dev)
> spin_unlock_bh(&bp->phy_lock);
> }
>
> -#define FW_BUF_SIZE 0x8000
> -
> +/* To be moved to generic lib/ */
> static int
> -bnx2_gunzip_init(struct bnx2 *bp)
> +bnx2_gunzip(void *gunzip_buf, unsigned sz, u8 *zbuf, int len, void **outbuf)
outbuf is no longer needed.
> + rc = zlib_inflateInit2(strm, -MAX_WBITS);
> + if (rc == Z_OK) {
> + rc = zlib_inflate(strm, Z_FINISH);
> + if (rc == Z_OK)
rc will always be Z_STREAM_END in this case since we provide a big
enough gunzip_buf for the whole blob.
next prev parent reply other threads:[~2007-09-21 1:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 17:23 bnx2 dirver's firmware images Denys Vlasenko
2007-09-18 18:45 ` Michael Chan
2007-09-18 17:55 ` Denys Vlasenko
2007-09-18 19:09 ` Michael Chan
2007-09-18 18:23 ` David Miller
2007-09-18 18:41 ` H. Peter Anvin
2007-09-18 19:20 ` David Miller
2007-09-18 19:27 ` H. Peter Anvin
2007-09-18 20:08 ` David Miller
2007-09-18 20:35 ` Sam Ravnborg
2007-09-18 20:40 ` H. Peter Anvin
2007-09-19 17:10 ` maximilian attems
2007-09-19 17:12 ` H. Peter Anvin
2007-09-19 17:18 ` maximilian attems
2007-09-19 17:37 ` Sam Ravnborg
2007-09-18 20:05 ` Michael Chan
2007-09-18 19:21 ` David Miller
2007-09-18 21:30 ` Willy Tarreau
2007-09-18 21:31 ` David Miller
2007-09-18 21:37 ` Willy Tarreau
2007-09-18 23:14 ` Michael Chan
2007-09-19 13:40 ` Bill Davidsen
2007-09-19 16:09 ` David Miller
2007-09-19 8:30 ` Denys Vlasenko
2007-09-19 21:00 ` Michael Chan
2007-09-19 20:29 ` Denys Vlasenko
2007-09-19 21:43 ` Michael Chan
2007-09-20 14:49 ` Denys Vlasenko
2007-09-21 2:12 ` Michael Chan [this message]
2007-09-19 16:33 ` maximilian attems
2007-09-19 16:38 ` David Miller
2007-09-19 16:51 ` maximilian attems
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190340753.6934.25.camel@dell \
--to=mchan@broadcom.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox