From: Thomas Gleixner <tglx@linutronix.de>
To: David Brownell <david-b@pacbell.net>
Cc: stable@kernel.org, linux-kernel@vger.kernel.org,
bene@linutronix.de, akpm@osdl.org
Subject: Re: [PATCH] usb-gadget-ether: Prevent oops caused by error interrupt race -V2 (comments update)
Date: Sat, 22 Sep 2007 21:30:40 +0200 [thread overview]
Message-ID: <1190489440.4035.103.camel@chaos> (raw)
In-Reply-To: <20070922191806.A2F59C2308@adsl-69-226-248-13.dsl.pltn13.pacbell.net>
On Sat, 2007-09-22 at 12:18 -0700, David Brownell wrote:
> I think you misread my comment. Those requests are **NOT** pending!!
> So this update has a *MORE* incorrect description of the issue.
>
> That's just the freelist ... it's a fairly conventional model whereby
> there's a pool of "free" request slots which can be issued. When the
> pool empties, the TX queue shuts down until one of the requests which
> is pending in the hardware completes, and makes a slot free.
>
> The problem you're addressing is that there's a small window where a
> disconnect IRQ can shut down the TX queue (and empty that freelist)
> after upper layers in the network stack started a transmission on
> an active (pre-disconnect) TX queue.
>
> That problem is *NOT* related to any pending requests at all!!
Sorry, I misunderstood your comment. Can you please add the correct
comment yourself before we play some more rounds of ping pong ?
tglx
next prev parent reply other threads:[~2007-09-22 19:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 14:46 [PATCH] usb-gadget-ether: Prevent oops caused by error interrupt race Thomas Gleixner
2007-09-21 22:08 ` David Brownell
2007-09-22 17:41 ` [PATCH] usb-gadget-ether: Prevent oops caused by error interrupt race -V2 (comments update) Thomas Gleixner
2007-09-22 19:18 ` David Brownell
2007-09-22 19:30 ` Thomas Gleixner [this message]
2007-09-22 20:14 ` David Brownell
2007-09-22 20:23 ` Thomas Gleixner
2007-09-22 20:53 ` David Brownell
2007-09-22 23:32 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190489440.4035.103.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=bene@linutronix.de \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox