From: Joe Perches <joe@perches.com>
To: Vegard Nossum <vegard.nossum@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
holzheu <holzheu@linux.vnet.ibm.com>,
Rob Landley <rob@landley.net>,
Dick Streefland <dick.streefland@altium.nl>
Subject: Re: [RFC] New kernel-message logging API
Date: Sun, 23 Sep 2007 12:25:15 -0700 [thread overview]
Message-ID: <1190575516.30132.48.camel@localhost> (raw)
In-Reply-To: <19f34abd0709230139s56b9a9b1yc2cae89488ea5112@mail.gmail.com>
On Sun, 2007-09-23 at 10:39 +0200, Vegard Nossum wrote:
> On 9/23/07, Joe Perches <joe@perches.com> wrote:
> > Given the number of 80 column zealots, character naming length
> > matters.
> I don't know. Compare the following two lines:
> printk(KERN_INFO "Message.\n");
> kprint_info("Message.");
The problem isn't printk(KERN_<level> to kprint_<level>(.
The problems are the no level printk(foo)s to kprint_<level>(foo)
and the pr_<level>() to kprint_<level>() translations.
> By dropping the lengthy macro (it's not like it's going to change
> while we're running anyway, so why not make it a part of the function
> name?) and the final newline, we actually end up with a net decrease
> in line length.
Which I do appreciate and think good.
> I thought it would be nice to have something that looks familiar,
> since that would ease an eventual transition. klog is a valid
> alternative, but isn't kp a bit cryptic?
Probably no more than pr_<level> is today.
cheers, Joe
next prev parent reply other threads:[~2007-09-23 19:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 19:27 [RFC] New kernel-message logging API Vegard Nossum
2007-09-23 0:13 ` Joe Perches
2007-09-23 0:40 ` Kyle Moffett
2007-09-23 0:47 ` Joe Perches
2007-09-23 3:43 ` Kyle Moffett
2007-09-23 8:39 ` Vegard Nossum
2007-09-23 8:45 ` Jan Engelhardt
2007-09-23 9:20 ` Vegard Nossum
2007-09-23 9:38 ` Jan Engelhardt
2007-09-23 19:23 ` Joe Perches
2007-09-23 19:25 ` Joe Perches [this message]
2007-09-23 1:05 ` Miguel Ojeda
2007-09-25 5:27 ` Vegard Nossum
2007-09-25 17:24 ` Miguel Ojeda
2007-09-23 20:05 ` Rob Landley
2007-09-24 9:22 ` Michael Holzheu
2007-09-24 15:19 ` Joe Perches
2007-09-24 16:43 ` Vegard Nossum
2007-09-24 17:00 ` Joe Perches
2007-09-24 20:37 ` Vegard Nossum
2007-09-25 1:18 ` Rob Landley
2007-09-24 23:51 ` Rob Landley
2007-09-25 0:10 ` Joe Perches
2007-09-25 1:46 ` Rob Landley
2007-09-25 8:57 ` Michael Holzheu
2007-09-24 18:26 ` Jesse Barnes
-- strict thread matches above, loose matches on Subject: below --
2007-09-25 4:58 linux
2007-09-25 6:54 ` Joe Perches
2007-09-25 7:50 ` linux
2007-09-25 8:06 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190575516.30132.48.camel@localhost \
--to=joe@perches.com \
--cc=dick.streefland@altium.nl \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rob@landley.net \
--cc=vegard.nossum@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox