From: Thomas Gleixner <tglx@linutronix.de>
To: Jeff Dike <jdike@addtoit.com>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>,
uml-devel <user-mode-linux-devel@lists.sourceforge.net>
Subject: Re: [PATCH] UML - time build fix
Date: Wed, 26 Sep 2007 00:08:47 +0200 [thread overview]
Message-ID: <1190758127.17409.81.camel@chaos> (raw)
In-Reply-To: <20070925215629.GA10926@c2.user-mode-linux.org>
Jeff,
On Tue, 2007-09-25 at 17:56 -0400, Jeff Dike wrote:
> On Tue, Sep 25, 2007 at 09:54:15PM +0200, Thomas Gleixner wrote:
> > On Tue, 2007-09-25 at 13:37 -0400, Jeff Dike wrote:
> > > Put back an implementation of timeval_to_ns in
> > > arch/um/os-Linux/time.c. tglx pointed out in his review of tickless
> > > support that there was a perfectly good implementation of it in
> > > linux/time.h. The problem is that this is userspace code which can't
> > > pull in kernel headers and there doesn't seem to be a libc version.
> >
> > Oops. Did not notice.
>
> It's a UML peculiarity...
>
> > Can't we move it into some header file which is accessible from everywhere ?
>
> Not in the generic kernel. UML has some generally includable headers
> of its own, but that doesn't really help.
>
> The one thing that would help is a libc timeval_to_ns.
Fair enough.
tglx
next prev parent reply other threads:[~2007-09-25 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 17:37 [PATCH] UML - time build fix Jeff Dike
2007-09-25 19:54 ` Thomas Gleixner
2007-09-25 21:56 ` Jeff Dike
2007-09-25 22:08 ` Thomas Gleixner [this message]
2007-09-26 15:46 ` [uml-devel] " Paolo Giarrusso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190758127.17409.81.camel@chaos \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox