From: Dave Hansen <haveblue@us.ibm.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [patch] fix sys_mknodat breakage from r/o bind mounts
Date: Tue, 25 Sep 2007 16:13:45 -0700 [thread overview]
Message-ID: <1190762025.26982.315.camel@localhost> (raw)
In-Reply-To: <E1IaJMd-000535-00@dorka.pomaz.szeredi.hu>
On Wed, 2007-09-26 at 00:58 +0200, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@suse.cz>
>
> mknod("foo", 0644) returns EINVAL, even though it should succeed.
Just to clarify, this is for when we use mknod to create normal,
non-device files, right? Your fix looks very correct to me.
I'm curious, do you have a normal program that uses mknod(2) this way?
I'd like to add it to my test scripts.
Acked-by: Dave Hansen <haveblue@us.ibm.com>
-- Dave
next prev parent reply other threads:[~2007-09-25 23:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 22:58 [patch] fix sys_mknodat breakage from r/o bind mounts Miklos Szeredi
2007-09-25 23:13 ` Dave Hansen [this message]
2007-09-25 23:18 ` Miklos Szeredi
2007-09-26 15:03 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190762025.26982.315.camel@localhost \
--to=haveblue@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox