From: Thomas Gleixner <tglx@linutronix.de>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: roel <12o3l@tiscali.nl>, lkml <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@shadowen.org>,
Randy Dunlap <rdunlap@xenotime.net>, Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] spin_lock_unlocked cleanups
Date: Fri, 28 Sep 2007 10:32:38 +0200 [thread overview]
Message-ID: <1190968358.18681.14.camel@chaos> (raw)
In-Reply-To: <20070928012656.0bae3991.akpm@linux-foundation.org>
On Fri, 2007-09-28 at 01:26 -0700, Andrew Morton wrote:
> On Fri, 28 Sep 2007 10:17:30 +0200 Thomas Gleixner <tglx@linutronix.de> wrote:
>
> > can we please add this to checkpatch.pl ?
> >
> > > -spinlock_t bpci_lock = SPIN_LOCK_UNLOCKED;
> > > +DEFINE_SPINLOCK(bpci_lock);
>
> That check is already in checkpatch. Problem is that hardly anyone
> runs the thing.
Sigh, I forgot that perl is write only. :)
> I think we're ready to wire checkpatch up to a email robot which monitors
> the mailing lists and sends people nastygrams. I bet that'll be popular ;)
We should wire it up to git-commit as well. A lot of that comes in via
git subsystems.
> (I'd love it if it could detect wordwrapped and tab-expanded patches, too.
> You wouldn't _believe_...)
I know ...
tglx
next prev parent reply other threads:[~2007-09-28 8:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 21:36 [PATCH] spin_lock_unlocked cleanups roel
2007-09-28 8:17 ` Thomas Gleixner
2007-09-28 8:26 ` Andrew Morton
2007-09-28 8:30 ` Ingo Molnar
2007-09-28 8:55 ` Andrew Morton
2007-09-28 8:32 ` Thomas Gleixner [this message]
2007-09-28 8:56 ` Andy Whitcroft
2007-09-28 9:06 ` Thomas Gleixner
2007-09-28 21:15 ` Sean
2007-09-28 8:53 ` Andy Whitcroft
2007-09-28 9:05 ` Andrew Morton
2007-09-28 17:31 ` Mark Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190968358.18681.14.camel@chaos \
--to=tglx@linutronix.de \
--cc=12o3l@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox