Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

Christoph Lameter
2007-09-12T21:24:29Z

On Wed, 12 Sep 2007, Mel Gorman wrote:

> - z++)
> - ;
> + if (likely(nodes == NULL))
> + for (; zonelist_zone_idx(z) > highest_zoneidx;
> + z++)
> + ;
> + else
> + for (; zonelist_zone_idx(z) > highest_zoneidx ||
> + (z->zone && !zref_in_nodemask(z, nodes));
> + z++)
> + ;
>

Minor nitpick here: "for (;" should become "for ( ;" to have correct
whitespace. However, it would be clearer to use a while here.

while (zonelist_zone_idx(z)) > highest_zoneidx)
z++;

etc.