Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

Mel Gorman
2007-09-13T10:25:42Z

On (12/09/07 14:23), Christoph Lameter didst pronounce:
> On Wed, 12 Sep 2007, Mel Gorman wrote:
>
> > - z++)
> > - ;
> > + if (likely(nodes == NULL))
> > + for (; zonelist_zone_idx(z) > highest_zoneidx;
> > + z++)
> > + ;
> > + else
> > + for (; zonelist_zone_idx(z) > highest_zoneidx ||
> > + (z->zone && !zref_in_nodemask(z, nodes));
> > + z++)
> > + ;
> >
>
> Minor nitpick here: "for (;" should become "for ( ;" to have correct
> whitespace. However, it would be clearer to use a while here.
>
> while (zonelist_zone_idx(z)) > highest_zoneidx)
> z++;
>
> etc.

Good point. I'll clean it up and retest. Thanks

--
Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab