Re: [PATCH] sky2: jumbo frame regression fix

Stephen Hemminger
2007-10-03T04:54:13Z

On Tue, 02 Oct 2007 21:07:22 -0400
Jeff Garzik <jgarzik@pobox.com> wrote:

> Stephen Hemminger wrote:
> > Remove unneeded check that caused problems with jumbo frame sizes.
> > The check was recently added and is wrong.
> > When using jumbo frames the sky2 driver does fragmentation, so
> > rx_data_size is less than mtu.
> >
> > Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
> >
> > --- a/drivers/net/sky2.c 2007-10-02 17:56:31.000000000 -0700
> > +++ b/drivers/net/sky2.c 2007-10-02 17:58:56.000000000 -0700
> > @@ -2163,9 +2163,6 @@ static struct sk_buff *sky2_receive(stru
> > sky2->rx_next = (sky2->rx_next + 1) % sky2->rx_pending;
> > prefetch(sky2->rx_ring + sky2->rx_next);
> >
> > - if (length < ETH_ZLEN || length > sky2->rx_data_size)
> > - goto len_error;
> > -
>
> 2.6.23? 2.6.24? enquiring minds want to know...

2.6.23, since it is a regression

--
Stephen Hemminger <shemminger@linux-foundation.org>