From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, Greg KH <greg@kroah.com>,
muli@il.ibm.com, paulus@samba.org, kristen.c.accardi@intel.com
Subject: Re: [patch take 2][Intel-IOMMU] Fix for IOMMU early crash
Date: Thu, 04 Oct 2007 11:19:33 +1000 [thread overview]
Message-ID: <1191460773.22572.139.camel@pasglop> (raw)
In-Reply-To: <20071003211327.GA14159@askeshav-devel.jf.intel.com>
> Index: 2.6-mm/include/linux/pci.h
> ===================================================================
> --- 2.6-mm.orig/include/linux/pci.h 2007-10-03 13:48:20.000000000 -0700
> +++ 2.6-mm/include/linux/pci.h 2007-10-03 13:49:08.000000000 -0700
> @@ -195,6 +195,7 @@
> #ifdef CONFIG_PCI_MSI
> struct list_head msi_list;
> #endif
> + void *iommu_private; /* hook for IOMMU specific extension */
> };
I'm not fan of this. That would imply that iommu stuff is specific to
PCI or that sort of thing.
Why don't you use the new struct dev_archdata mechanism ? That's what I
use on powerpc to provide optional iommu linkage to any device in the
system.
Ben.
next prev parent reply other threads:[~2007-10-04 1:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 20:05 [RFC][Intel-IOMMU] Fix for IOMMU early crash Keshavamurthy, Anil S
2007-09-09 11:16 ` Muli Ben-Yehuda
2007-09-10 15:43 ` Keshavamurthy, Anil S
2007-09-09 17:51 ` Muli Ben-Yehuda
2007-09-11 17:22 ` Keshavamurthy, Anil S
2007-09-09 17:37 ` Paul Mackerras
2007-09-11 17:42 ` Keshavamurthy, Anil S
2007-09-10 20:25 ` Muli Ben-Yehuda
2007-09-11 20:43 ` Keshavamurthy, Anil S
2007-09-12 19:28 ` [patch][Intel-IOMMU] " Keshavamurthy, Anil S
2007-09-11 19:48 ` Paul Mackerras
2007-09-12 21:55 ` Keshavamurthy, Anil S
2007-09-11 22:05 ` [BUG:] forcedeth: MCP55 not allowing DHCP Casey Dahlin
2007-09-18 1:59 ` Casey Dahlin
2007-09-13 1:29 ` [patch][Intel-IOMMU] Fix for IOMMU early crash Keshavamurthy, Anil S
2007-09-14 16:30 ` Paul Mackerras
2007-09-25 17:07 ` Keshavamurthy, Anil S
2007-10-03 21:13 ` [patch take 2][Intel-IOMMU] " Keshavamurthy, Anil S
2007-10-04 1:19 ` Benjamin Herrenschmidt [this message]
2007-10-04 1:36 ` Keshavamurthy, Anil S
2007-10-04 3:39 ` Benjamin Herrenschmidt
2007-10-04 19:20 ` Keshavamurthy, Anil S
2007-10-05 3:08 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191460773.22572.139.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=greg@kroah.com \
--cc=kristen.c.accardi@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@il.ibm.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox