From: Jun WANG <junwang1234@gmail.com>
To: penguin-kernel@i-love.sakura.ne.jp
Cc: linux-kernel@vger.kernel.org
Subject: Re:Sleeping in RCU list traversal
Date: Mon, 08 Oct 2007 03:11:47 +0800 [thread overview]
Message-ID: <1191784307.3618.8.camel@localhost.localdomain> (raw)
Hi
>Something like this?
>
>rcu_read_lock();
>list_for_each_rcu(p, ...) {
> ptr = list_entry(p, struct ..., list);
> /* Grab a reference to "ptr". */
> rcu_read_unlock();
> my_task_that_may_sleep(ptr);
> rcu_read_lock();
> /* Drop a reference to "ptr". */
>}
>rcu_read_unlock();
>Regarding my case, memory region pointed by "ptr" never be removed.
>Do I need to grab a reference to "ptr" ?
In Document/RCU/whatisRCU.txt
Note that the value returned by rcu_dereference() is valid
only within the enclosing RCU read-side critical section.
For example, the following is -not- legal:
rcu_read_lock();
p = rcu_dereference(head.next);
rcu_read_unlock();
x = p->address;
rcu_read_lock();
y = p->data;
rcu_read_unlock();
Holding a reference from one RCU read-side critical section
to another is just as illegal as holding a reference from
one lock-based critical section to another! Similarly,
using a reference outside of the critical section in which
it was acquired is just as illegal as doing so with normal
locking.
Jun Wang
next reply other threads:[~2007-10-07 11:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-07 19:11 Jun WANG [this message]
2007-10-07 13:26 ` Sleeping in RCU list traversal Tetsuo Handa
2007-10-07 22:37 ` Jun WANG
2007-10-07 16:56 ` Tetsuo Handa
2007-10-07 18:33 ` Peter Zijlstra
2007-10-07 19:56 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191784307.3618.8.camel@localhost.localdomain \
--to=junwang1234@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox