From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755240AbXJJBCs (ORCPT ); Tue, 9 Oct 2007 21:02:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751537AbXJJBCj (ORCPT ); Tue, 9 Oct 2007 21:02:39 -0400 Received: from mga01.intel.com ([192.55.52.88]:29317 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751632AbXJJBCi (ORCPT ); Tue, 9 Oct 2007 21:02:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.21,251,1188802800"; d="scan'208";a="340728655" Subject: Re: [PATCH -mm -v4 0/3] i386/x86_64 boot: 32-bit boot protocol From: "Huang, Ying" To: "H. Peter Anvin" Cc: Andi Kleen , "Eric W. Biederman" , akpm@linux-foundation.org, Yinghai Lu , Chandramouli Narayanan , linux-kernel@vger.kernel.org In-Reply-To: <470BD539.9020703@zytor.com> References: <1191912003.9719.17.camel@caritas-dev.intel.com> <470BD539.9020703@zytor.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 10 Oct 2007 09:03:56 +0800 Message-Id: <1191978236.9719.101.camel@caritas-dev.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.10.3 X-OriginalArrivalTime: 10 Oct 2007 01:01:47.0709 (UTC) FILETIME=[2224FED0:01C80AD9] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2007-10-09 at 12:23 -0700, H. Peter Anvin wrote: > Huang, Ying wrote: > > > > - Which fields of boot parameters should be exported directly in > > sysfs? Export all fields of boot parameters in sysfs is too complex > > and unnecessary. Which fields should be? > > > > The main this is that since this is a fixed-format, ABI-defined > structure, regardless of individual fields it should be exported as a > binary object. That is also the only way to deal with a kernel which > may not itself know about specific items making the data available to > other users, like kexec. > > It's not clear to me from reading the code what model you're using for > exporting this data in sysfs. Could you describe it in some detail? > > What I had envisioned would be an object for the boot_params structure > and a systematic object for each linked-list object, at a very minimum. > OK. The directory structure is as follow: + sys + kernel + boot_params - version /* version of boot protocol */ - data /* binary file of boot_params */ + setup_data + 0 - type /* type id of setup_data 0 */ - data /* binary file of setup_data 0 */ + 1 - type /* type id of setup_data 1 */ - data /* binary file of setup_data 1 */ + 2 - type - data ... Best Regards, Huang Ying