From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, daniel@qanu.de, holger@qanu.de,
video4linux-list@redhat.com,
v4l-dvb maintainer list <v4l-dvb-maintainer@linuxtv.org>
Subject: Re: [PATCH 3/3] V4L: cinergyT2, remove bad usage of ERESTARTSYS
Date: Tue, 09 Oct 2007 22:21:00 -0300 [thread overview]
Message-ID: <1191979260.5492.32.camel@gaivota> (raw)
In-Reply-To: <24841282012868130110@pripojeni.net>
Hi Jiri,
Em Seg, 2007-10-08 às 13:41 +0100, Jiri Slaby escreveu:
> cinergyT2, remove bad usage of ERESTARTSYS
>
> test of cinergyt2->disconnect_pending doesn't ensure pending signal and so
> ERESTARTSYS would reach userspace, which is not permitted. Change it to
> EAGAIN
>
checkpatch.pl is complaining about your changeset:
do not use assignment in if condition
#82: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:492:
+ if ((err = mutex_lock_interruptible(&cinergyt2->wq_sem)))
do not use assignment in if condition
#86: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:495:
+ if ((err = mutex_lock_interruptible(&cinergyt2->sem)))
do not use assignment in if condition
#133: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:1036:
+ if ((err = mutex_lock_interruptible(&cinergyt2->wq_sem)))
do not use assignment in if condition
#137: FILE: drivers/media/dvb/cinergyT2/cinergyT2.c:1039:
+ if ((err = mutex_lock_interruptible(&cinergyt2->sem)))
Please fix.
Cheers,
Mauro
next prev parent reply other threads:[~2007-10-10 1:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-08 12:33 [PATCH 1/3] V4L: w9968cf, remove bad usage of ERESTARTSYS Jiri Slaby
2007-10-08 12:34 ` [PATCH 2/3] V4L: zc0301, " Jiri Slaby
2007-10-10 0:18 ` Luca Risolia
2007-10-08 12:34 ` [PATCH 3/3] V4L: cinergyT2, " Jiri Slaby
2007-10-10 1:21 ` Mauro Carvalho Chehab [this message]
2007-10-10 4:18 ` [v4l-dvb-maintainer] " Michael Krufky
2007-10-10 15:35 ` Mauro Carvalho Chehab
2007-10-10 15:59 ` Alan Cox
2007-10-10 16:17 ` Mauro Carvalho Chehab
2007-10-10 16:40 ` Manu Abraham
2007-10-10 16:53 ` Marcel Siegert
2007-10-10 17:05 ` Manu Abraham
2007-10-10 18:04 ` Marcel Siegert
2007-10-12 4:29 ` Randy Dunlap
2007-10-10 0:18 ` [PATCH 1/3] V4L: w9968cf, " Luca Risolia
2007-10-14 14:28 ` [PATCH 1/1 try 2] V4L: cinergyT2, " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1191979260.5492.32.camel@gaivota \
--to=mchehab@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=daniel@qanu.de \
--cc=holger@qanu.de \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox