* [PATCH] v4l: copy_to_user() is not a good method name
@ 2007-10-13 7:25 Al Viro
2007-10-13 11:33 ` Christoph Hellwig
2007-10-13 13:20 ` Mauro Carvalho Chehab
0 siblings, 2 replies; 3+ messages in thread
From: Al Viro @ 2007-10-13 7:25 UTC (permalink / raw)
To: Linus Torvalds; +Cc: mchehab, linux-kernel
Breaks on any target that has copy_to_user() defined as a non-trivial
macro.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
diff --git a/drivers/media/video/videobuf-core.c b/drivers/media/video/videobuf-core.c
index c606332..5599a36 100644
--- a/drivers/media/video/videobuf-core.c
+++ b/drivers/media/video/videobuf-core.c
@@ -674,7 +674,7 @@ ssize_t videobuf_read_one(struct videobuf_queue *q,
}
/* Copy to userspace */
- retval=CALL(q,copy_to_user,q,data,count,nonblocking);
+ retval=CALL(q,video_copy_to_user,q,data,count,nonblocking);
if (retval<0)
goto done;
diff --git a/drivers/media/video/videobuf-dma-sg.c b/drivers/media/video/videobuf-dma-sg.c
index 8bb7fdd..3eb6123 100644
--- a/drivers/media/video/videobuf-dma-sg.c
+++ b/drivers/media/video/videobuf-dma-sg.c
@@ -670,7 +670,7 @@ static struct videobuf_qtype_ops pci_ops = {
.sync = __videobuf_sync,
.mmap_free = __videobuf_mmap_free,
.mmap_mapper = __videobuf_mmap_mapper,
- .copy_to_user = __videobuf_copy_to_user,
+ .video_copy_to_user = __videobuf_copy_to_user,
.copy_stream = __videobuf_copy_stream,
};
diff --git a/drivers/media/video/videobuf-vmalloc.c b/drivers/media/video/videobuf-vmalloc.c
index 2e3689a..cd74341 100644
--- a/drivers/media/video/videobuf-vmalloc.c
+++ b/drivers/media/video/videobuf-vmalloc.c
@@ -320,7 +320,7 @@ static struct videobuf_qtype_ops qops = {
.sync = __videobuf_sync,
.mmap_free = __videobuf_mmap_free,
.mmap_mapper = __videobuf_mmap_mapper,
- .copy_to_user = __videobuf_copy_to_user,
+ .video_copy_to_user = __videobuf_copy_to_user,
.copy_stream = __videobuf_copy_stream,
};
diff --git a/include/media/videobuf-core.h b/include/media/videobuf-core.h
index 9fa09fb..0fa5d59 100644
--- a/include/media/videobuf-core.h
+++ b/include/media/videobuf-core.h
@@ -133,7 +133,7 @@ struct videobuf_qtype_ops {
enum v4l2_memory memory);
int (*sync) (struct videobuf_queue* q,
struct videobuf_buffer *buf);
- int (*copy_to_user) (struct videobuf_queue *q,
+ int (*video_copy_to_user)(struct videobuf_queue *q,
char __user *data,
size_t count,
int nonblocking);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l: copy_to_user() is not a good method name
2007-10-13 7:25 [PATCH] v4l: copy_to_user() is not a good method name Al Viro
@ 2007-10-13 11:33 ` Christoph Hellwig
2007-10-13 13:20 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2007-10-13 11:33 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, mchehab, linux-kernel
On Sat, Oct 13, 2007 at 08:25:24AM +0100, Al Viro wrote:
> Breaks on any target that has copy_to_user() defined as a non-trivial
> macro.
Where did that CALL crap come from? We normally don;t accept junk like
that.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l: copy_to_user() is not a good method name
2007-10-13 7:25 [PATCH] v4l: copy_to_user() is not a good method name Al Viro
2007-10-13 11:33 ` Christoph Hellwig
@ 2007-10-13 13:20 ` Mauro Carvalho Chehab
1 sibling, 0 replies; 3+ messages in thread
From: Mauro Carvalho Chehab @ 2007-10-13 13:20 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, linux-kernel
Em Sáb, 2007-10-13 às 08:25 +0100, Al Viro escreveu:
> Breaks on any target that has copy_to_user() defined as a non-trivial
> macro.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Acked-by: Mauro Carvalho Chehab <mchehab@infradead.org>
Cheers,
Mauro
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-13 13:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-13 7:25 [PATCH] v4l: copy_to_user() is not a good method name Al Viro
2007-10-13 11:33 ` Christoph Hellwig
2007-10-13 13:20 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox