From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1765844AbXJQODM (ORCPT ); Wed, 17 Oct 2007 10:03:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758314AbXJQOC4 (ORCPT ); Wed, 17 Oct 2007 10:02:56 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:35481 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758148AbXJQOCz (ORCPT ); Wed, 17 Oct 2007 10:02:55 -0400 Subject: Re: [PATCH 1/4] fix not-and/or errors From: Peter Zijlstra To: Roel Kluin <12o3l@tiscali.nl> Cc: lkml In-Reply-To: <47161243.6060007@tiscali.nl> References: <47161243.6060007@tiscali.nl> Content-Type: text/plain Date: Wed, 17 Oct 2007 16:02:51 +0200 Message-Id: <1192629771.27435.120.camel@twins> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2007-10-17 at 15:46 +0200, Roel Kluin wrote: > if(!x & y) should either be if(!(x & y)) or if(!x && y) > I made changes as seemed appropriate, but please review > this is against current git. > > Signed-off-by: Roel Kluin <12o3l@tiscali.nl> Not being familiar with any of the code touched, the choices look good. Acked-by: Peter Zijlstra