Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

Maciej W. Rozycki
2007-10-18T11:37:53Z

On Thu, 18 Oct 2007, Jarek Poplawski wrote:

> After rethinking, it looks like this last cancel should be useless.
> So, if phy_interrupt() schedules only if !PHY_HALTED and phy_change()
> does enable_irq() with no exeptions, it seems phy_interrupt() even
> without lock must see PHY_HALTED state before this free_irq() with
> possible DEBUG_SHIRQ call, then maybe only this safety:
>
> WARN_ON(work_pending(&phydev->phy_queue));

Good point.

Maciej