Re: [PATCH] PHYLIB: IRQ event workqueue handling fixes

Maciej W. Rozycki
2007-10-19T17:59:04Z

On Fri, 19 Oct 2007, Jarek Poplawski wrote:

> Actually I'm not convinced with this explanation. It seems to me that
> since there are such serious locking problems (especially with rntl),
> there could be once more considered a private workqueue. You've
> written earlier about being a lonely user of this code. But, since

Well, this will change eventually when I submit the patch for Broadcom
SiByte platforms so that sb1250-mac.c will be able to request an interrupt
for the PHYs. All the infrastructure is in place except from platform
code to configure the SOC's GPIO line used for the interrupt input (when
applicable) and let the driver know what the line actually is.

> Benjamin offered his help with changing to mutexes, which looks like
> very reasonable idea to me (probably I miss most of the points...),
> maybe it's very good opportunity to both: make this code better and
> double the user base! I'm interested in looking for such solution
> if Benjamin thinks there could be too few problems for him... So,
> let somebody tell us what could be wrong with this idea?

I do not object and can certainly cooperate, but cannot make it a high
priority work for me at the moment -- sorry.

Maciej