From: Avi Kivity <avi@qumranet.com>
To: kvm-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org,
Laurent Vivier <Laurent.Vivier@bull.net>,
Avi Kivity <avi@qumranet.com>
Subject: [PATCH 09/11] KVM: Move kvm_guest_exit() after local_irq_enable()
Date: Sun, 21 Oct 2007 13:08:10 +0200 [thread overview]
Message-ID: <11929648921683-git-send-email-avi@qumranet.com> (raw)
In-Reply-To: <1192964892617-git-send-email-avi@qumranet.com>
From: Laurent Vivier <Laurent.Vivier@bull.net>
We need to make sure that the timer interrupt happens before we clear
PF_VCPU, so the accounting code actually sees guest mode.
http://lkml.org/lkml/2007/10/15/114
Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>
Signed-off-by: Avi Kivity <avi@qumranet.com>
---
drivers/kvm/kvm_main.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c
index af2d288..8c458f2 100644
--- a/drivers/kvm/kvm_main.c
+++ b/drivers/kvm/kvm_main.c
@@ -2054,12 +2054,21 @@ again:
kvm_x86_ops->run(vcpu, kvm_run);
- kvm_guest_exit();
vcpu->guest_mode = 0;
local_irq_enable();
++vcpu->stat.exits;
+ /*
+ * We must have an instruction between local_irq_enable() and
+ * kvm_guest_exit(), so the timer interrupt isn't delayed by
+ * the interrupt shadow. The stat.exits increment will do nicely.
+ * But we need to prevent reordering, hence this barrier():
+ */
+ barrier();
+
+ kvm_guest_exit();
+
preempt_enable();
/*
--
1.5.3
next prev parent reply other threads:[~2007-10-21 11:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-21 11:08 [PATCH 00/11] KVM updates for Linux 2.6.24-rc review Avi Kivity
2007-10-21 11:08 ` [PATCH 01/11] KVM: x86 emulator: fix merge screwup due to emulator split Avi Kivity
2007-10-21 11:08 ` [PATCH 02/11] KVM: x86 emulator: fix repne/repnz decoding Avi Kivity
2007-10-21 11:08 ` [PATCH 03/11] KVM: MMU: Set shadow pte atomically in mmu_pte_write_zap_pte() Avi Kivity
2007-10-21 11:08 ` [PATCH 04/11] KVM: VMX: Handle NMIs before enabling interrupts and preemption Avi Kivity
2007-10-21 11:08 ` [PATCH 05/11] KVM: VMX: Reset mmu context when entering real mode Avi Kivity
2007-10-21 11:08 ` [PATCH 06/11] KVM: x86 emulator: implement 'movnti mem, reg' Avi Kivity
2007-10-21 11:08 ` [PATCH 07/11] KVM: VMX: Force vm86 mode if setting flags during real mode Avi Kivity
2007-10-21 11:08 ` [PATCH 08/11] KVM: x86 emulator: fix access registers for instructions with ModR/M byte and Mod = 3 Avi Kivity
2007-10-21 11:08 ` Avi Kivity [this message]
2007-10-21 11:08 ` [PATCH 10/11] KVM: Fix local apic timer divide by zero Avi Kivity
2007-10-21 11:08 ` [PATCH 11/11] KVM: Improve local apic timer wraparound handling Avi Kivity
2007-10-21 11:12 ` [PATCH 00/11] KVM updates for Linux 2.6.24-rc review Avi Kivity
2007-10-21 11:53 ` Laurent Vivier
2007-10-21 12:07 ` Avi Kivity
2007-10-21 12:38 ` [kvm-devel] " Laurent Vivier
2007-10-22 9:36 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11929648921683-git-send-email-avi@qumranet.com \
--to=avi@qumranet.com \
--cc=Laurent.Vivier@bull.net \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox