public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kay Sievers <kay.sievers@vrfy.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Greg KH <greg@kroah.com>,
	Kernel development list <linux-kernel@vger.kernel.org>
Subject: Re: BUG in: Driver core: convert block from raw kobjects to core devices
Date: Tue, 23 Oct 2007 02:01:21 +0200	[thread overview]
Message-ID: <1193097681.2107.9.camel@lov.site> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0710212014130.25357-100000@netrider.rowland.org>

On Sun, 2007-10-21 at 20:26 -0400, Alan Stern wrote:
> On Sun, 21 Oct 2007, Kay Sievers wrote:
> 
> > > [  458.013133] scsi_disk_release: disk sda, kobj ce8be990, refcount before put_disk 2
> > > [  458.032420] scsi_device_dev_release: rq cd9b2000
> > 
> > Hmm, I still don't see this without the final put.
> 
> Yes, I see your point.  Suppose you try doing the exact same thing
> again, but this time un-comment the put_device() call so that the
> scsi_device does get released.  I predict that the log will show your
> request_queue drops its reference to the gendisk structure _after_ the
> gendisk has been released.  (If necessary I could send a patch with a
> printk at the crucial spot.)  That would prove something is going wrong
> on your system.

There is definitely something wrong, I tried all sorts of options now,
and a second machine, and I can never get the behavior you see. I even
booted with init=/bin/sh.
But true, looking at the kobject debugging for loop devices, and usb
storage driven by the ub driver, all looks fine without the additional
put.

There must be something going wrong with the block patch in conjunction
with the crazy SCSI release logic. Can you send me your .config? Just
for a check, maybe you have some option, enabled/disabled that changes
the behavior, and possibly brings us closer to find the bug.

Thanks,
Kay


  reply	other threads:[~2007-10-22 23:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-18 19:23 BUG in: Driver core: convert block from raw kobjects to core devices Alan Stern
2007-10-18 19:27 ` Greg KH
2007-10-18 19:27 ` Kay Sievers
2007-10-18 20:08   ` Alan Stern
2007-10-19  1:27     ` Kay Sievers
2007-10-19 14:09       ` Alan Stern
2007-10-19 14:15         ` Kay Sievers
2007-10-19 17:11           ` Alan Stern
2007-10-19 23:06             ` Kay Sievers
2007-10-21  1:33               ` Alan Stern
2007-10-21 19:03                 ` Kay Sievers
2007-10-22  0:26                   ` Alan Stern
2007-10-23  0:01                     ` Kay Sievers [this message]
2007-10-23  4:14                       ` Alan Stern
2007-10-23 11:27                         ` Kay Sievers
2007-10-24 18:01                           ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1193097681.2107.9.camel@lov.site \
    --to=kay.sievers@vrfy.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox