From: Joe Perches <joe@perches.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: Stringbuf, v2
Date: Wed, 24 Oct 2007 13:51:37 -0700 [thread overview]
Message-ID: <1193259097.19617.18.camel@localhost> (raw)
In-Reply-To: <20071024195847.GE27248@parisc-linux.org>
On Wed, 2007-10-24 at 13:58 -0600, Matthew Wilcox wrote:
> - Pass a gfp_t to sb_printk
sb_printf
As it doesn't actually output anything but extends
a buffer pointer in a struct, perhaps it's better to
rename sb_printf to sb_sprintf.
I believe the common use will be GFP_ATOMIC.
Perhaps a default wrapper define and a renamed function?
void sb_sprintf_gfp(struct stringbuf *sb, gfp_t gfp, const char *fmt, ...)
#define sb_sprintf(sb, fmt, arg...) \
sb_sprintf_gfp(sb, GFP_ATOMIC, fmt, ##arg)
next prev parent reply other threads:[~2007-10-24 20:52 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 19:58 Stringbuf, v2 Matthew Wilcox
2007-10-24 19:59 ` [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-24 19:59 ` [PATCH 2/4] isdn: Use stringbuf Matthew Wilcox
2007-10-24 19:59 ` [PATCH 3/4] sound: " Matthew Wilcox
2007-10-24 19:59 ` [PATCH 4/4] partitions: Fix non-atomic printk Matthew Wilcox
2007-10-24 20:59 ` [PATCH 1/4] stringbuf: A string buffer implementation Kyle Moffett
2007-10-24 21:21 ` Matthew Wilcox
2007-10-25 0:07 ` Kyle Moffett
2007-10-25 3:23 ` Matthew Wilcox
2007-10-26 2:11 ` Rusty Russell
2007-10-26 3:41 ` Joe Perches
2007-10-26 5:05 ` Joe Perches
2007-10-26 11:57 ` Matthew Wilcox
2007-10-26 20:57 ` Matt Mackall
2007-10-27 10:09 ` Rusty Russell
2007-10-29 3:03 ` Matt Mackall
2007-10-29 5:38 ` Rusty Russell
2007-10-27 11:47 ` Pekka Enberg
2007-10-27 12:50 ` Rusty Russell
2007-10-27 16:34 ` Pekka Enberg
2007-10-27 16:48 ` Matthew Wilcox
2007-10-24 20:51 ` Joe Perches [this message]
2007-10-24 20:57 ` Stringbuf, v2 Matthew Wilcox
2007-10-24 21:06 ` Joe Perches
2007-10-24 21:34 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193259097.19617.18.camel@localhost \
--to=joe@perches.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox