From: Thomas Renninger <trenn@suse.de>
To: Jean Delvare <khali@linux-fr.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-acpi <linux-acpi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict]
Date: Thu, 25 Oct 2007 16:13:47 +0200 [thread overview]
Message-ID: <1193321627.4590.278.camel@queen.suse.de> (raw)
In-Reply-To: <20071025154833.0240b8a2@hyperion.delvare>
On Thu, 2007-10-25 at 15:48 +0200, Jean Delvare wrote:
> Hi Andrew,
>
> On Wed, 24 Oct 2007 20:53:47 -0700, Andrew Morton wrote:
> > On Wed, 24 Oct 2007 16:33:07 +0200 Thomas Renninger <trenn@suse.de> wrote:
> >
> > > From: Thomas Renninger <trenn@suse.de>
> > > To: linux-acpi <linux-acpi@vger.kernel.org>
> > > Cc: linux-kernel <linux-kernel@vger.kernel.org>, Len Brown <lenb@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Jean Delvare <khali@linux-fr.org>
> > > Reply-To: trenn@suse.de
> > > Subject: [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict]
> > > Date: Wed, 24 Oct 2007 16:33:07 +0200
> > > Organization: Novell/SUSE
> > > X-Mailer: Evolution 2.8.2
> > >
> > > Export acpi_check_resource_conflict(), sometimes drivers already have
> > > a struct resource at hand so no need to use the wrappers to build a new
> > > one.
> > >
> > > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > > ---
> >
> > The attributions on this are all mucked up.
> >
> > I _think_ it was written by Jean, in which case the changlog should
> > have had From:him right at the start to indicate this. And as you
> > were in the delivery path, it should have had your signoff.
> >
> > I'll make those changes - please let me know if I misguessed.
>
> You are correct, patches 3/5, 4/5 and 5/5 of this patchset were written
> by me (as in: I'm the one to blame if something breaks). I expected
> Thomas to add a From: header and add his own Signed-off-by line but
> instead he forwarded my mails directly. Thanks for fixing up the mess,
> we'll try to make it better next time.
As said, I wasn't sure against what I should base all this.
I would had cleaned it up, depending on what you told me. I also didn't
know about the From: tag if you send patches not from your own, the next
time...
Anyways, it's nice to see how things can move on right away without much
delay and discussion.
Thanks,
Thomas
prev parent reply other threads:[~2007-10-25 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 14:33 [Fwd: [PATCH 3/5] Export acpi_check_resource_conflict] Thomas Renninger
2007-10-25 3:53 ` Andrew Morton
2007-10-25 13:48 ` Jean Delvare
2007-10-25 14:13 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193321627.4590.278.camel@queen.suse.de \
--to=trenn@suse.de \
--cc=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox