Re: [PATCH 1/3 -v4] x86_64 EFI runtime service support: EFI basic runtime service support

Eric W. Biederman
2007-10-25T17:32:44Z

"H. Peter Anvin" <hpa@zytor.com> writes:

> Andi Kleen wrote:
>>> Especially for accessing the real time clock that has a well
>>> defined hardware interface going through efi an additional
>>> software emulation layer looks like asking for trouble.
>>
>> I agree it's pointless for the hardware clock, but EFI also offers services to
>> write some data to the CMOS RAM
>> which could be very useful to save oops data over reboot.
>> I don't think this can be done safely otherwise without BIOS cooperation.
>>
>
> The ability to scurry away even a small amount of data without relying on the
> disk system is highly desirable. Think next-boot type information.

Yes. If that were to be the justifying case and if that was what
the code was implementing I could see the point.

However this point was made in an earlier review. This point
was already been made, and still this patchset doesn't
include that functionality and it still includes the code
to disable direct hardware access for no seemingly sane
reason.

Eric