From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
paulus@samba.org, shaggy@austin.ibm.com, adaplas@gmail.com,
"Morton, Andrew" <akpm@linux-foundation.org>,
xfs-masters@oss.sgi.com
Subject: Re: [interesting] smattering of possible memory ordering bugs
Date: Fri, 26 Oct 2007 14:32:27 +1000 [thread overview]
Message-ID: <1193373147.7018.70.camel@pasglop> (raw)
In-Reply-To: <200710261347.35545.nickpiggin@yahoo.com.au>
On Fri, 2007-10-26 at 13:47 +1000, Nick Piggin wrote:
> I don't think the previous code was wrong... it's not a locked section
> > and we don't care about ordering previous stores. It's an
> allocation, it
> > should be fine. In general, bitmap allocators should be allright.
>
> Well if it is just allocating an arbitrary _number_ out of a bitmap
> and nothing else (eg. like the pid allocator), then you don't need
> barriers.
Yup, that's what it does.
Cheers,
Ben.
next prev parent reply other threads:[~2007-10-26 4:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 2:09 [interesting] smattering of possible memory ordering bugs Nick Piggin
2007-10-26 3:35 ` Benjamin Herrenschmidt
2007-10-26 3:47 ` Nick Piggin
2007-10-26 4:32 ` Benjamin Herrenschmidt [this message]
2007-10-26 13:45 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193373147.7018.70.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=adaplas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=paulus@samba.org \
--cc=shaggy@austin.ibm.com \
--cc=xfs-masters@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox