From: Kay Sievers <kay.sievers@vrfy.org>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Greg KH <gregkh@suse.de>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rjw@sisk.pl>, Pavel Machek <pavel@ucw.cz>,
jbarnes@virtuousgeek.org
Subject: Re: fixing up DRM device model usage
Date: Sat, 27 Oct 2007 23:12:15 +0200 [thread overview]
Message-ID: <1193519535.5776.16.camel@lov.site> (raw)
In-Reply-To: <200710261431.48589.jesse.barnes@intel.com>
On Fri, 2007-10-26 at 14:31 -0700, Jesse Barnes wrote:
> On Friday, October 26, 2007 12:08 pm Kay Sievers wrote:
> > The open coded: device_create_file(&dev->dev, &device_attrs[i])
> > should probably replaced by passing the array to the class, and the
> > core will do that for you.
>
> You mean just set drm_class->dev_attrs = device_attrs? I didn't see in
> the core device model code where that would create the files...
Yeah, it is in device_add_attrs() in drivers/base/core.c.
Kay
prev parent reply other threads:[~2007-10-27 21:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-18 21:01 [RFC] full suspend/resume support for i915 DRM driver Jesse Barnes
2007-10-20 2:51 ` Jesse Barnes
2007-10-23 4:15 ` Jesse Barnes
2007-10-24 20:17 ` Adrian Bunk
2007-10-24 21:07 ` Jesse Barnes
2007-10-24 13:35 ` Pavel Machek
2007-10-24 15:18 ` Jesse Barnes
2007-10-24 21:22 ` Rafael J. Wysocki
2007-10-25 23:53 ` Jesse Barnes
2007-10-26 4:59 ` Greg KH
2007-10-26 16:57 ` Jesse Barnes
2007-10-26 17:10 ` Kay Sievers
2007-10-26 18:12 ` Jesse Barnes
2007-10-26 18:21 ` Kay Sievers
2007-10-26 18:40 ` fixing up DRM device model usage Jesse Barnes
2007-10-26 19:08 ` Kay Sievers
2007-10-26 21:31 ` Jesse Barnes
2007-10-27 21:12 ` Kay Sievers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1193519535.5776.16.camel@lov.site \
--to=kay.sievers@vrfy.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=jesse.barnes@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox