Re: [RFC] kobject and kset core changes and cleanups

Andrew Morton
2007-11-06T08:04:57Z

On Fri, 2 Nov 2007 16:57:58 -0700 Greg KH <gregkh@suse.de> wrote:

> So, I go on vacation for a week or so and come back to an overflowing
> inbox. Instead of trying to wade through all of that, I decide to
> finish up the work Kay and I had started on cleaning up the kset core
> code.

fs/ocfs2/stackglue.c:940: error: expected ')' before '(' token
fs/ocfs2/stackglue.c: In function 'ocfs2_show':
fs/ocfs2/stackglue.c:948: error: 'ocfs2_subsys' undeclared (first use in this function)
fs/ocfs2/stackglue.c:948: error: (Each undeclared identifier is reported only once
fs/ocfs2/stackglue.c:948: error: for each function it appears in.)
fs/ocfs2/stackglue.c: In function 'ocfs2_store':
fs/ocfs2/stackglue.c:962: error: 'ocfs2_subsys' undeclared (first use in this function)
fs/ocfs2/stackglue.c: In function 'ocfs2_sys_shutdown':
fs/ocfs2/stackglue.c:972: error: 'ocfs2_subsys' undeclared (first use in this function)
fs/ocfs2/stackglue.c: In function 'ocfs2_sys_init':
fs/ocfs2/stackglue.c:979: error: 'ocfs2_subsys' undeclared (first use in this function)
fs/ocfs2/stackglue.c:980: error: implicit declaration of function 'kobj_set_kset_s'
fs/ocfs2/stackglue.c:980: error: 'fs_subsys' undeclared (first use in this function)

wrecks the ocfs2 devel tree. I'll drop that too.

I wonder how much other out-of-tree code will be broken.