Re: [PATCH 33/54] driver core: remove fields from struct bus_type

Cornelia Huck
2007-11-05T10:33:44Z

On Fri, 2 Nov 2007 16:59:11 -0700,
Greg Kroah-Hartman <gregkh@suse.de> wrote:

> struct bus_type is static everywhere in the kernel. This moves the
> kobject in the structure out of it, and a bunch of other private only to
> the driver core fields are now moved to a private structure. This lets
> us dynamically create the backing kobject properly and gives us the
> chance to be able to document to users exactly how to use the struct
> bus_type as there are no fields they can improperly access.
>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> ---
> drivers/base/base.h | 30 +++++++++++-
> drivers/base/bus.c | 120 ++++++++++++++++++++++++++--------------------
> drivers/base/core.c | 6 +-
> drivers/base/dd.c | 4 +-
> drivers/base/driver.c | 2 +-
> drivers/base/platform.c | 4 +-
> include/linux/device.h | 12 +----
> 7 files changed, 107 insertions(+), 71 deletions(-)
>

drivers/base/bus.c: In function 'make_deprecated_bus_links':
drivers/base/bus.c:428: error: 'struct bus_type' has no member named 'subsys'

Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

---
drivers/base/bus.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/base/bus.c
===================================================================
--- linux-2.6.orig/drivers/base/bus.c 2007-11-05 11:12:49.000000000 +0100
+++ linux-2.6/drivers/base/bus.c 2007-11-05 11:30:28.000000000 +0100
@@ -425,7 +425,7 @@ static void device_remove_attrs(struct b
static int make_deprecated_bus_links(struct device *dev)
{
return sysfs_create_link(&dev->kobj,
- &dev->bus->subsys.kobj, "bus");
+ &dev->bus->p->subsys.kobj, "bus");
}

static void remove_deprecated_bus_links(struct device *dev)