Re: [PATCH 38/54] efivars: remove new_var and del_var files from sysfs

Greg KH
2007-11-27T06:07:50Z

On Fri, Nov 16, 2007 at 09:01:16AM -0600, Matt Domsch wrote:
> On Fri, Nov 02, 2007 at 04:59:16PM -0700, Greg Kroah-Hartman wrote:
> > WTF? Passing binary structures into a sysfs file, expecting it to be in
> > the correct format/endianness? That's just wrong on so many levels.
> >
> > So, these files are deleted. If you want to add them back, please do so
> > in configfs, or in debugfs. Or use text strings, which is what sysfs is
> > only for.
>
>
> I have tested gregkh's patches tree, which includes this patch, the
> patch to put these back as binary blob interfaces, as well as other
> cleanups, on an Itanium2 system. The efibootmgr userspace application
> continues to work as it did before this patch series, which I claim is
> success. For the patches that touch drivers/firmware/efivars.c I can
> say:
>
> Tested-by: Matt Domsch <Matt_Domsch@dell.com>

Great, thanks for doing this, I appreciate it.

greg k-h