Re: [PATCH 34/54] Driver Core: add kobj_attribute handling

Greg KH
2007-11-05T20:02:37Z

On Mon, Nov 05, 2007 at 07:59:50PM +0100, Cornelia Huck wrote:
> On Mon, 05 Nov 2007 19:39:31 +0100,
> Kay Sievers <kay.sievers@vrfy.org> wrote:
>
> > Where are the objects that join this kset? A kset is a "collection of
> > objects of a similar type", If there are no objects, you don't need a
> > kset at all, I guess, but just a plain directory. :)
>
> Yes, ipl.c looks a lot like "we need a subdirectory under /sys/firmware/
> and need to jump through hoops to get it there".

In looking at all of the users of the firmware subdirectory, that is
what they are all needing that subdirectory for.

Ugh, I'll go change that up and delete that kset, and a few of the other
ksets as they just need to be directories, not full-blown ksets.

> > Anyway, seems we need an easy way to pass default attributes to ksets
> > and plain directories. If userspace should set some values here when a
> > subsystems creates the its sysfs representation, we must make sure, that
> > the attributes exist at the time the event is sent, otherwise we will
> > run into all sorts of timing problems.
>
> Maybe they need something like device->uevent_suppress, but at the
> kobject level?

Ugh, I hope not :)

thanks,

greg k-h