Re: [PATCH 46/54] kset: convert s390 ipl.c to use kset_create

Greg KH
2007-11-05T17:21:49Z

On Mon, Nov 05, 2007 at 11:27:31AM +0100, Cornelia Huck wrote:
> On Fri, 2 Nov 2007 16:59:24 -0700,
> Greg Kroah-Hartman <gregkh@suse.de> wrote:
>
> > Dynamically create the kset instead of declaring it statically.
> > This makes the kobject attributes now work properly that I broke in the
> > previous patch.
> >
> > Cc: Kay Sievers <kay.sievers@vrfy.org>
> > Cc: Michael Holzheu <holzheu@de.ibm.com>
> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> > Cc: Volker Sameske <sameske@de.ibm.com>
> > Cc: Cornelia Huck <cornelia.huck@de.ibm.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
> > ---
> > arch/s390/kernel/ipl.c | 75 +++++++++++++++++++++++++-----------------------
> > 1 files changed, 39 insertions(+), 36 deletions(-)
>
> It seems you also need this (not yet booted):
>
> Fix the following warnings:
>
> arch/s390/kernel/ipl.c: In function 'reipl_init':
> arch/s390/kernel/ipl.c:981: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type
> arch/s390/kernel/ipl.c: In function 'dump_init':
> arch/s390/kernel/ipl.c:1070: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type
> arch/s390/kernel/ipl.c: In function 'shutdown_actions_init':
> arch/s390/kernel/ipl.c:1094: warning: passing argument 2 of 'sysfs_create_file' from incompatible pointer type
>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>

Thanks, but this should go with the previous kobject_attribute cleanup
patch, not the kset patch. I've merged it in now.

thanks for the review and patch.

greg k-h