Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig

Dave Jones
2007-11-06T07:38:45Z

On Sun, Nov 04, 2007 at 12:51:11AM +0100, Sam Ravnborg wrote:

> @@ -26,7 +29,7 @@ config X86_ACPI_CPUFREQ
> config ELAN_CPUFREQ
> tristate "AMD Elan SC400 and SC410"
> select CPU_FREQ_TABLE
> - depends on X86_ELAN
> + depends on X86_32 && X86_ELAN
> ---help---
> This adds the CPUFreq driver for AMD Elan SC400 and SC410
> processors.
> @@ -42,7 +45,7 @@ config ELAN_CPUFREQ
> config SC520_CPUFREQ
> tristate "AMD Elan SC520"
> select CPU_FREQ_TABLE
> - depends on X86_ELAN
> + depends on X86_32 && X86_ELAN
> ---help---
> This adds the CPUFreq driver for AMD Elan SC520 processor.

X86_ELAN should depend on X86_32 rather than adding this everywhere.

> config X86_POWERNOW_K7
> tristate "AMD Mobile Athlon/Duron PowerNow!"
> select CPU_FREQ_TABLE
> + depends on X86_32
> help
> This adds the CPUFreq driver for mobile AMD K7 mobile processors.
>
> @@ -76,23 +81,27 @@ config X86_POWERNOW_K7_ACPI
> bool
> depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
> depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
> + depends on X86_32
> default y

This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
which you just added the 32bit dependancy to.

> config X86_SPEEDSTEP_RELAXED_CAP_CHECK
> bool "Relaxed speedstep capability checks"
> - depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> + depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)

Should also be unnecessary due to those items now being 32bit dependant.

Dave

--