Re: [PATCH 01/10] x86: unification of cfufreq/Kconfig

Sam Ravnborg
2007-11-06T08:12:16Z

> > + depends on X86_32 && X86_ELAN
> > ---help---
> > This adds the CPUFreq driver for AMD Elan SC520 processor.
>
> X86_ELAN should depend on X86_32 rather than adding this everywhere.

...

> > bool
> > depends on X86_POWERNOW_K7 && ACPI_PROCESSOR
> > depends on !(X86_POWERNOW_K7 = y && ACPI_PROCESSOR = m)
> > + depends on X86_32
> > default y
>
> This 2nd hunk shouldn't be necessary, as it depends on X86_POWERNOW_K7
> which you just added the 32bit dependancy to.
>
> > config X86_SPEEDSTEP_RELAXED_CAP_CHECK
> > bool "Relaxed speedstep capability checks"
> > - depends on (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
> > + depends on X86_32 && (X86_SPEEDSTEP_SMI || X86_SPEEDSTEP_ICH)
>
> Should also be unnecessary due to those items now being 32bit dependant.

In several cases the "depends on X86_32 were added not as a necessity
but just to make it obvious that a given symbol is 32 bit specific.
I can drop doing it this way if it is anyway obvious from the context.

Will try to do so in next patch-set, due tonigt if things goes OK.

Sam