Re: [PATCH 02/10] x86: start unification of arch/x86/Kconfig.*

Adrian Bunk
2007-11-04T01:44:33Z

On Sun, Nov 04, 2007 at 12:51:12AM +0100, Sam Ravnborg wrote:
>...
> --- a/arch/x86/Kconfig.x86_64
> +++ b/arch/x86/Kconfig.x86_64
>...
> # x86-64 doesn't support PCI BIOS access from long mode so always go direct.
> config PCI_DIRECT
> @@ -737,36 +723,11 @@ config PCI_DIRECT
> depends on PCI
> default y
>
> -config PCI_MMCONFIG
> - bool "Support mmconfig PCI config space access"
> - depends on PCI && ACPI
> -
> config PCI_DOMAINS
> bool
> depends on PCI
> default y
>
> -config DMAR
> - bool "Support for DMA Remapping Devices (EXPERIMENTAL)"
> - depends on PCI_MSI && ACPI && EXPERIMENTAL
> - help
> - DMA remapping (DMAR) devices support enables independent address
> - translations for Direct Memory Access (DMA) from devices.
> - These DMA remapping devices are reported via ACPI tables
> - and include PCI device scope covered by these DMA
> - remapping devices.
> -
> -config DMAR_GFX_WA
> - bool "Support for Graphics workaround"
> - depends on DMAR
> - default y
> - help
> - Current Graphics drivers tend to use physical address
> - for DMA and avoid using DMA APIs. Setting this config
> - option permits the IOMMU driver to set a unity map for
> - all the OS-visible memory. Hence the driver can continue
> - to use physical addresses for DMA.
> -
> config DMAR_FLOPPY_WA
> bool
> depends on DMAR
>...

In patch 8 the remaining PCI_* options and DMAR_FLOPPY_WA end in a
completely different place in the Kconfig file than the options moved
here.

Please keep options that belong together grouped together no matter
whether all of them are user visible.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed