Re: [PATCH 03/10] x86: arch/x86/Kconfig.cpu unification

Brian Gerst
2007-11-06T00:54:25Z

Sam Ravnborg wrote:
> Move all CPU definitions to Kconfig.cpu

This patch causes build failure on x86_64:

lib/rwsem.c: In function ‘__init_rwsem’:
lib/rwsem.c:24: error: ‘struct rw_semaphore’ has no member named ‘count’
lib/rwsem.c:24: error: ‘RWSEM_UNLOCKED_VALUE’ undeclared (first use in
this function)
lib/rwsem.c:24: error: (Each undeclared identifier is reported only once
lib/rwsem.c:24: error: for each function it appears in.)
lib/rwsem.c: In function ‘__rwsem_do_wake’:
lib/rwsem.c:64: error: implicit declaration of function
‘rwsem_atomic_update’
lib/rwsem.c:64: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in this
function)
lib/rwsem.c:66: error: ‘RWSEM_ACTIVE_MASK’ undeclared (first use in this
function)
lib/rwsem.c:115: error: ‘RWSEM_WAITING_BIAS’ undeclared (first use in
this function)
lib/rwsem.c:120: error: implicit declaration of function ‘rwsem_atomic_add’
lib/rwsem.c: In function ‘rwsem_down_failed_common’:
lib/rwsem.c:169: error: ‘RWSEM_ACTIVE_MASK’ undeclared (first use in
this function)
lib/rwsem.c: In function ‘rwsem_down_read_failed’:
lib/rwsem.c:197: error: ‘RWSEM_WAITING_BIAS’ undeclared (first use in
this function)
lib/rwsem.c:197: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in
this function)
lib/rwsem.c: In function ‘rwsem_down_write_failed’:
lib/rwsem.c:210: error: ‘RWSEM_ACTIVE_BIAS’ undeclared (first use in
this function)

git bisect gives:
55432d383871d127685d78f94e0ad60307dcc0e9 is first bad commit
commit 55432d383871d127685d78f94e0ad60307dcc0e9
Author: Sam Ravnborg <sam@ravnborg.org>
Date: Thu Nov 1 21:54:39 2007 +0100

x86: arch/x86/Kconfig.cpu unification